Skip to content

Commit 34b39df

Browse files
committed
1 parent 1c49517 commit 34b39df

File tree

10 files changed

+40
-21
lines changed

10 files changed

+40
-21
lines changed

ci/nightly/pipeline.template.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2427,6 +2427,7 @@ steps:
24272427
MZ_GHCR: 0
24282428
agents:
24292429
queue: hetzner-aarch64-8cpu-16gb
2430+
skip: "https://github.com/MaterializeInc/materialize/pull/34214"
24302431

24312432
- id: orchestratord-upgrade-combine
24322433
label: "Orchestratord test (upgrade, combine props)"
@@ -2442,6 +2443,7 @@ steps:
24422443
MZ_GHCR: 0
24432444
agents:
24442445
queue: hetzner-aarch64-8cpu-16gb
2446+
skip: "https://github.com/MaterializeInc/materialize/pull/34214"
24452447

24462448
- id: orchestratord-upgrade-chain-individual
24472449
label: "Orchestratord test (upgrade chain, individual props)"
@@ -2457,6 +2459,7 @@ steps:
24572459
MZ_GHCR: 0
24582460
agents:
24592461
queue: hetzner-aarch64-8cpu-16gb
2462+
skip: "https://github.com/MaterializeInc/materialize/pull/34214"
24602463

24612464
- id: orchestratord-upgrade-chain-combine
24622465
label: "Orchestratord test (upgrade chain, combine props)"
@@ -2472,3 +2475,4 @@ steps:
24722475
MZ_GHCR: 0
24732476
agents:
24742477
queue: hetzner-aarch64-16cpu-32gb
2478+
skip: "https://github.com/MaterializeInc/materialize/pull/34214"

ci/plugins/cloudtest/hooks/command

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ ci_uncollapsed_heading "cloudtest: Running \`$TEST_CMD\`"
7575
TEST_RESULT=0
7676

7777
cleanup() {
78+
# Don't run the cleanup function twice
79+
trap - EXIT SIGTERM SIGINT
80+
7881
echo "--- Post command steps"
7982
# Buildkite exposes no way to check if a test timed out (and wasn't cancelled manually), so we have to calculate it ourselves
8083
START_TIME=$(date -d "$STEP_START_TIMESTAMP" +%s)
@@ -185,8 +188,6 @@ cleanup() {
185188
sudo systemctl restart docker
186189
docker ps --all --quiet | xargs --no-run-if-empty docker rm --force --volumes
187190

188-
# Don't run the cleanup function twice
189-
trap - EXIT SIGTERM SIGINT
190191
exit "$CI_ANNOTATE_ERRORS_RESULT"
191192
}
192193

ci/plugins/mzcompose/hooks/command

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,9 @@ ci_uncollapsed_heading ":docker: Running \`$TEST_CMD\`"
9292
echo "$TEST_DESC"
9393

9494
cleanup() {
95+
# Don't run the cleanup function twice
96+
trap - EXIT SIGTERM SIGINT
97+
9598
# Buildkite exposes no way to check if a test timed out (and wasn't cancelled manually), so we have to calculate it ourselves
9699
START_TIME=$(date -d "$STEP_START_TIMESTAMP" +%s)
97100
END_TIME=$(date +%s)
@@ -351,8 +354,6 @@ cleanup() {
351354
bin/clear-corrupted-cargo-target-dir run.log
352355
fi
353356

354-
# Don't run the cleanup function twice
355-
trap - EXIT SIGTERM SIGINT
356357
exit "$CI_ANNOTATE_ERRORS_RESULT"
357358
}
358359

doc/developer/testdrive.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -933,41 +933,43 @@ a version of Materialize that is able to execute the SQL constructs contained th
933933

934934
```
935935
$ skip-if
936-
SELECT mz_version_num() < 2601;
936+
SELECT mz_version_num() < 2600203;
937937
```
938938

939+
The above example references v26.2.3
940+
939941
## Run an action/query conditionally on version
940942

941943
```
942-
>[version>=13000] SELECT 1;
944+
>[version>=2600203] SELECT 1;
943945
1
944946
```
945947

946-
The `[version>=13000]` property allows running the action or query only when we are connected to a Materialize instance with a compatible version. The supported comparison operators are `>`, `>=`, `=`, `<=` and `<`. The version number is the same as returned from [`mz_version_num()`](https://materialize.com/docs/sql/functions/#system-information-functions) and has the same format `XXYYYZZ`, where `XX` is the major version, `YYY` is the minor version and `ZZ` is the patch version. So in the example we are only running the `SELECT 1` query if the Materialize instance is of version `v0.130.0` or higher. For lower versions no query is run and no comparison of results is performed subsequently.
948+
The `[version>=2600203]` property allows running the action or query only when we are connected to a Materialize instance with a compatible version. The supported comparison operators are `>`, `>=`, `=`, `<=` and `<`. The version number is the same as returned from [`mz_version_num()`](https://materialize.com/docs/sql/functions/#system-information-functions) and has the same format `XXYYYZZ`, where `XX` is the major version, `YYY` is the minor version and `ZZ` is the patch version. So in the example we are only running the `SELECT 1` query if the Materialize instance is of version `v26.2.3` or higher. For lower versions no query is run and no comparison of results is performed subsequently.
947949

948950
You can bound the version above and below using the following syntax:
949951

950952
```
951-
>[13500<=version<14300] SELECT 1;
953+
>[2600203<=version<2600300] SELECT 1;
952954
1
953955
```
954956

955957
You can use `<` or `<=` freely. The following are equivalent:
956958

957959
```
958-
>[version>14300] SELECT 1;
960+
>[version>2600300] SELECT 1;
959961
1
960-
>[14300<version] SELECT 1;
962+
>[2600300<version] SELECT 1;
961963
1
962964
```
963965

964-
If you change the result of a query in version `v0.148.0-dev` for example, you have to keep the old version working in Platform Checks as well as Testdrive/MySQL CDC/Postgres CDC with old syntax for migration tests, since they may run the code with both an older Materialize version and the currently tested one. To do that, you can duplicate the query and version-gate it accordingly:
966+
If you change the result of a query in version `v26.3.0-dev` for example, you have to keep the old version working in Platform Checks as well as Testdrive/MySQL CDC/Postgres CDC with old syntax for migration tests, since they may run the code with both an older Materialize version and the currently tested one. To do that, you can duplicate the query and version-gate it accordingly:
965967

966968
```
967-
?[version<14800] EXPLAIN SELECT * FROM t1 AS a1, t1 AS a2 WHERE a1.f1 IS NOT NULL;
969+
?[version<2600300] EXPLAIN SELECT * FROM t1 AS a1, t1 AS a2 WHERE a1.f1 IS NOT NULL;
968970
[OLD QUERY PLAN HERE]
969971
970-
?[version>=14800] EXPLAIN SELECT * FROM t1 AS a1, t1 AS a2 WHERE a1.f1 IS NOT NULL;
972+
?[version>=2600300] EXPLAIN SELECT * FROM t1 AS a1, t1 AS a2 WHERE a1.f1 IS NOT NULL;
971973
[NEW QUERY PLAN HERE]
972974
```
973975

doc/user/content/releases/v26.0.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ title: "Materialize v26.0"
33
date: 2025-11-19
44
released: true
55
patch: 0
6-
rc: 1
76
_build:
87
render: never
98
---

doc/user/content/releases/v26.1.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
title: "Materialize v26.1"
33
date: 2025-11-26
44
released: false
5+
rc: 1
56
_build:
67
render: never
78
---

misc/python/materialize/checks/all_checks/statement_logging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def initialize(self) -> Testdrive:
2222
$ postgres-execute connection=postgres://mz_system@${testdrive.materialize-internal-sql-addr}
2323
ALTER SYSTEM SET statement_logging_max_sample_rate TO 1.0
2424
25-
$[version>=2600100] postgres-execute connection=postgres://mz_system@${testdrive.materialize-internal-sql-addr}
25+
$[version>=2600200] postgres-execute connection=postgres://mz_system@${testdrive.materialize-internal-sql-addr}
2626
ALTER SYSTEM SET enable_frontend_peek_sequencing = false;
2727
"""
2828
)

misc/python/materialize/release/mark_release_complete.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"""Mark a minor release series as complete."""
1111

1212
import argparse
13+
import re
1314
import sys
1415

1516
from materialize import git, spawn
@@ -26,11 +27,11 @@ def main():
2627

2728
print(f"Marking {args.release_version} as released in the docs...")
2829
release_version_doc_file = doc_file_path(args.release_version)
29-
release_version_doc_file.write_text(
30-
release_version_doc_file.read_text().replace(
31-
"released: false", f"released: true\npatch: {args.patch}"
32-
)
30+
text = release_version_doc_file.read_text().replace(
31+
"released: false", f"released: true\npatch: {args.patch}"
3332
)
33+
text = re.sub(r"^rc: .*$\n?", "", text, flags=re.MULTILINE)
34+
release_version_doc_file.write_text(text)
3435
git.add_file(str(release_version_doc_file))
3536
git.commit_all_changed(f"release: mark {args.release_version} as released")
3637

test/cluster/mzcompose.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3701,7 +3701,7 @@ def workflow_statement_logging(c: Composition, parser: WorkflowArgumentParser) -
37013701
c.testdrive(
37023702
input=dedent(
37033703
"""
3704-
$[version>=2600100] postgres-execute connection=postgres://mz_system@${testdrive.materialize-internal-sql-addr}
3704+
$ postgres-execute connection=postgres://mz_system@${testdrive.materialize-internal-sql-addr}
37053705
ALTER SYSTEM SET enable_frontend_peek_sequencing = false;
37063706
"""
37073707
)

test/terraform/mzcompose.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1244,7 +1244,17 @@ def workflow_azure_temporary(c: Composition, parser: WorkflowArgumentParser) ->
12441244
path = MZ_ROOT / "test" / "terraform" / "azure-temporary"
12451245
state = State(path)
12461246

1247-
spawn.runv(["bin/ci-builder", "run", "stable", "uv", "venv", str(path / "venv")])
1247+
spawn.runv(
1248+
[
1249+
"bin/ci-builder",
1250+
"run",
1251+
"stable",
1252+
"uv",
1253+
"venv",
1254+
"--clear",
1255+
str(path / "venv"),
1256+
],
1257+
)
12481258
venv_env = os.environ.copy()
12491259
venv_env["PATH"] = f"{path/'venv'/'bin'}:{os.getenv('PATH')}"
12501260
venv_env["VIRTUAL_ENV"] = str(path / "venv")

0 commit comments

Comments
 (0)