Skip to content

Commit 3b28351

Browse files
def-antiguru
andauthored
miri test: Disable new unsupported tests (#32104)
Seen in https://buildkite.com/materialize/nightly/builds/11711#0196084e-eaa8-4f23-8321-b063630a71ce Follow-up to #32083 ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post. --------- Signed-off-by: Moritz Hoffmann <mh@materialize.com> Co-authored-by: Moritz Hoffmann <mh@materialize.com>
1 parent e1ae73a commit 3b28351

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/expr-derive-impl/src/lib.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ pub fn test_sqlfunc_str(attr: &str, item: &str) -> (String, String) {
5454
mod test {
5555
use quote::quote;
5656

57+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
5758
#[mz_ore::test]
5859
fn insta_test_add_int16() {
5960
let attr = quote! {
@@ -75,6 +76,7 @@ mod test {
7576
insta::assert_snapshot!("add_int16", output, &input);
7677
}
7778

79+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
7880
#[mz_ore::test]
7981
fn insta_test_unary() {
8082
let attr = quote! {};
@@ -87,6 +89,7 @@ mod test {
8789
insta::assert_snapshot!("unary_fn", output, &input);
8890
}
8991

92+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
9093
#[mz_ore::test]
9194
fn insta_test_unary_arena() {
9295
let attr = quote! {};
@@ -99,6 +102,7 @@ mod test {
99102
insta::assert_snapshot!("unary_arena_fn", output, &input);
100103
}
101104

105+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
102106
#[mz_ore::test]
103107
fn insta_test_unary_ref() {
104108
let attr = quote! {};
@@ -111,6 +115,7 @@ mod test {
111115
insta::assert_snapshot!("unary_ref", output, &input);
112116
}
113117

118+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
114119
#[mz_ore::test]
115120
fn insta_test_complex_output_type() {
116121
let attr = quote! {
@@ -129,6 +134,7 @@ mod test {
129134
insta::assert_snapshot!("complex_type", output, &input);
130135
}
131136

137+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
132138
#[mz_ore::test]
133139
fn insta_test_binary_arena() {
134140
let attr = quote! {};

src/expr-derive-impl/src/sqlfunc.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ fn generate_test(attr: TokenStream, item: TokenStream, name: &Ident) -> TokenStr
8484

8585
quote! {
8686
#[cfg(test)]
87+
#[cfg_attr(miri, ignore)] // unsupported operation: extern static `pidfd_spawnp` is not supported by Miri
8788
#[mz_ore::test]
8889
fn #test_name() {
8990
let (output, input) = mz_expr_derive_impl::test_sqlfunc_str(#attr, #item);

0 commit comments

Comments
 (0)