Skip to content

Commit 5e5ebe9

Browse files
committed
Fix test
Signed-off-by: Moritz Hoffmann <mh@materialize.com>
1 parent e5cee16 commit 5e5ebe9

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/compute/src/render/reduce.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2038,7 +2038,7 @@ fn finalize_accum<'a>(aggr_func: &'a AggregateFunc, accum: &'a Accum, total: Dif
20382038
}
20392039
}
20402040

2041-
/// The type for accumulator counting. Set to [`Overflowing<u128>`]
2041+
/// The type for accumulator counting. Set to [`Overflowing<u128>`](mz_ore::Overflowing).
20422042
type AccumCount = mz_ore::Overflowing<i128>;
20432043

20442044
/// Accumulates values for the various types of accumulable aggregations.

src/ore/src/overflowing.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#[cfg(feature = "proptest")]
2020
use proptest_derive::Arbitrary;
2121
use serde::{Deserialize, Serialize};
22-
#[cfg(feature = "proptest")]
2322
use std::ops::{Add, AddAssign, Div, Mul, Neg, Rem, Sub, SubAssign};
2423

2524
/// Overflowing number. Operations panic on overflow, even in release mode.
@@ -667,9 +666,10 @@ mod overflowing_support {
667666
match mode {
668667
#[cfg(not(target_arch = "wasm32"))]
669668
MODE_SOFT_PANIC => crate::soft_panic_or_log!("Overflow: {description}"),
670-
// We cannot use the logging `soft_panic_or_log` in wasm, so we skip logging instead.
669+
// We cannot use the logging `soft_panic_or_log` in wasm, so we panic instead (soft
670+
// assertions are always enabled in wasm).
671671
#[cfg(target_arch = "wasm32")]
672-
MODE_SOFT_PANIC => crate::soft_panic_no_log!("Overflow: {description}"),
672+
MODE_SOFT_PANIC => panic!("Overflow: {description}"),
673673
MODE_PANIC => panic!("Overflow: {description}"),
674674
// MODE_IGNORE and all other (impossible) values
675675
_ => {}

0 commit comments

Comments
 (0)