Add integration test for new config variables

Author: SangJunBak

src/environmentd/BUILD.bazel

@@ -284,6 +284,72 @@ rust_test(
     ),
 )
 
+rust_test(
+    name = "mz_environmentd_bootstrap_builtin_clusters_tests",
+    size = "large",
+    srcs = ["tests/bootstrap_builtin_clusters.rs"],
+    aliases = aliases(
+        normal = True,
+        normal_dev = True,
+        proc_macro = True,
+        proc_macro_dev = True,
+    ),
+    compile_data = [],
+    crate_features = [],
+    crate_name = "bootstrap_builtin_clusters",
+    data = [],
+    env = {},
+    proc_macro_deps = [] + all_crate_deps(
+        proc_macro = True,
+        proc_macro_dev = True,
+    ),
+    rustc_env = {},
+    rustc_flags = [],
+    version = "0.133.0-dev.0",
+    deps = [
+        "//src/adapter:mz_adapter",
+        "//src/adapter-types:mz_adapter_types",
+        "//src/alloc:mz_alloc",
+        "//src/alloc-default:mz_alloc_default",
+        "//src/aws-secrets-controller:mz_aws_secrets_controller",
+        "//src/build-info:mz_build_info",
+        "//src/catalog:mz_catalog",
+        "//src/cloud-resources:mz_cloud_resources",
+        "//src/controller:mz_controller",
+        "//src/dyncfgs:mz_dyncfgs",
+        "//src/environmentd:mz_environmentd",
+        "//src/frontegg-auth:mz_frontegg_auth",
+        "//src/frontegg-mock:mz_frontegg_mock",
+        "//src/http-util:mz_http_util",
+        "//src/interchange:mz_interchange",
+        "//src/metrics:mz_metrics",
+        "//src/orchestrator:mz_orchestrator",
+        "//src/orchestrator-kubernetes:mz_orchestrator_kubernetes",
+        "//src/orchestrator-process:mz_orchestrator_process",
+        "//src/orchestrator-tracing:mz_orchestrator_tracing",
+        "//src/orchestratord:mz_orchestratord",
+        "//src/ore:mz_ore",
+        "//src/persist-client:mz_persist_client",
+        "//src/pgrepr:mz_pgrepr",
+        "//src/pgtest:mz_pgtest",
+        "//src/pgwire:mz_pgwire",
+        "//src/pgwire-common:mz_pgwire_common",
+        "//src/prof-http:mz_prof_http",
+        "//src/repr:mz_repr",
+        "//src/secrets:mz_secrets",
+        "//src/segment:mz_segment",
+        "//src/server-core:mz_server_core",
+        "//src/service:mz_service",
+        "//src/sql:mz_sql",
+        "//src/sql-parser:mz_sql_parser",
+        "//src/storage-types:mz_storage_types",
+        "//src/tracing:mz_tracing",
+    ] + all_crate_deps(
+        normal = True,
+        normal_dev = True,
+    ),
+)
+
 rust_test(
     name = "mz_environmentd_cli_tests",
     size = "large",

src/environmentd/src/test_util.rs

@@ -279,6 +279,16 @@ impl TestHarness {
         self.builtin_system_cluster_config.size = builtin_system_cluster_replica_size;
         self
     }
+
+    pub fn with_builtin_system_cluster_replication_factor(
+        mut self,
+        builtin_system_cluster_replication_factor: u32,
+    ) -> Self {
+        self.builtin_system_cluster_config.replication_factor =
+            builtin_system_cluster_replication_factor;
+        self
+    }
+
     pub fn with_builtin_catalog_server_cluster_replica_size(
         mut self,
         builtin_catalog_server_cluster_replica_size: String,
@@ -287,7 +297,6 @@ impl TestHarness {
             builtin_catalog_server_cluster_replica_size;
         self
     }
-    // TODO: Add with_builtin_probe_cluster_replica_size
 
     pub fn with_propagate_crashes(mut self, propagate_crashes: bool) -> Self {
         self.propagate_crashes = propagate_crashes;

src/environmentd/tests/bootstrap_builtin_clusters.rs

@@ -0,0 +1,39 @@
+// Copyright Materialize, Inc. and contributors. All rights reserved.
+//G
+// Use of this software is governed by the Business Source License
+// included in the LICENSE file.
+//
+// As of the Change Date specified in that file, in accordance with
+// the Business Source License, use of this software will be governed
+// by the Apache License, Version 2.0.
+
+//! Integration tests for builtin clusters on bootstrap.
+
+use mz_environmentd::test_util::{self};
+
+// Test that a cluster with a replication factor of 0 should not create any replicas.
+#[mz_ore::test]
+fn test_zero_replication_factor_no_replicas() {
+    let server = test_util::TestHarness::default()
+        .with_builtin_system_cluster_replication_factor(0)
+        .start_blocking();
+
+    let mut client = server.connect(postgres::NoTls).unwrap();
+    let system_cluster = client
+        .query_one(
+            r#"
+    SELECT c.id, c.name, c.replication_factor::integer, COUNT(cr.id)::integer as replica_count 
+    FROM mz_clusters c
+    LEFT JOIN mz_cluster_replicas cr ON c.id = cr.cluster_id
+    WHERE c.name = 'mz_system'
+    GROUP BY c.id, c.name, c.replication_factor
+    "#,
+            &[],
+        )
+        .unwrap();
+
+    let replication_factor: i32 = system_cluster.get(2);
+    let replica_count: i32 = system_cluster.get(3);
+    assert_eq!(replication_factor, 0);
+    assert_eq!(replica_count, 0);
+}

src/sqllogictest/BUILD.bazel

@@ -29,6 +29,7 @@ rust_library(
     rustc_flags = [],
     version = "0.0.1",
     deps = [
+        "//src/adapter-types:mz_adapter_types",
         "//src/build-info:mz_build_info",
         "//src/catalog:mz_catalog",
         "//src/controller:mz_controller",
@@ -73,6 +74,7 @@ rust_test(
     rustc_flags = [],
     version = "0.0.1",
     deps = [
+        "//src/adapter-types:mz_adapter_types",
         "//src/build-info:mz_build_info",
         "//src/catalog:mz_catalog",
         "//src/controller:mz_controller",
@@ -102,6 +104,7 @@ rust_doc_test(
     name = "mz_sqllogictest_doc_test",
     crate = ":mz_sqllogictest",
     deps = [
+        "//src/adapter-types:mz_adapter_types",
         "//src/build-info:mz_build_info",
         "//src/catalog:mz_catalog",
         "//src/controller:mz_controller",
@@ -151,6 +154,7 @@ rust_test(
     version = "0.0.1",
     deps = [
         ":mz_sqllogictest",
+        "//src/adapter-types:mz_adapter_types",
         "//src/build-info:mz_build_info",
         "//src/catalog:mz_catalog",
         "//src/controller:mz_controller",
@@ -194,6 +198,7 @@ rust_binary(
     version = "0.0.1",
     deps = [
         ":mz_sqllogictest",
+        "//src/adapter-types:mz_adapter_types",
         "//src/build-info:mz_build_info",
         "//src/catalog:mz_catalog",
         "//src/controller:mz_controller",