Remove expiration_days from bucket lifecycle rule

Author: bobbyiliev

README.md

@@ -53,6 +53,12 @@ module "materialize_infrastructure" {
 
 > **Note:** The Kubernetes and Helm providers are configured to use the AWS CLI for authentication with the EKS cluster. This requires that you have the AWS CLI installed and configured with access to the AWS account where the EKS cluster is deployed.
 
+You can also set the `AWS_PROFILE` environment variable to the name of the profile you want to use for authentication with the EKS cluster:
+
+```bash
+export AWS_PROFILE=your-profile-name
+```
+
 ## Requirements
 
 | Name | Version |
@@ -98,7 +104,7 @@ module "materialize_infrastructure" {
 |------|-------------|------|---------|:--------:|
 | <a name="input_availability_zones"></a> [availability\_zones](#input\_availability\_zones) | List of availability zones | `list(string)` | <pre>[<br/>  "us-east-1a",<br/>  "us-east-1b",<br/>  "us-east-1c"<br/>]</pre> | no |
 | <a name="input_bucket_force_destroy"></a> [bucket\_force\_destroy](#input\_bucket\_force\_destroy) | Enable force destroy for the S3 bucket | `bool` | `true` | no |
-| <a name="input_bucket_lifecycle_rules"></a> [bucket\_lifecycle\_rules](#input\_bucket\_lifecycle\_rules) | List of lifecycle rules for the S3 bucket | <pre>list(object({<br/>    id                                 = string<br/>    enabled                            = bool<br/>    prefix                             = string<br/>    transition_days                    = number<br/>    transition_storage_class           = string<br/>    expiration_days                    = number<br/>    noncurrent_version_expiration_days = number<br/>  }))</pre> | <pre>[<br/>  {<br/>    "enabled": true,<br/>    "expiration_days": 365,<br/>    "id": "cleanup",<br/>    "noncurrent_version_expiration_days": 90,<br/>    "prefix": "",<br/>    "transition_days": 90,<br/>    "transition_storage_class": "STANDARD_IA"<br/>  }<br/>]</pre> | no |
+| <a name="input_bucket_lifecycle_rules"></a> [bucket\_lifecycle\_rules](#input\_bucket\_lifecycle\_rules) | List of lifecycle rules for the S3 bucket | <pre>list(object({<br/>    id                                 = string<br/>    enabled                            = bool<br/>    prefix                             = string<br/>    transition_days                    = number<br/>    transition_storage_class           = string<br/>    noncurrent_version_expiration_days = number<br/>  }))</pre> | <pre>[<br/>  {<br/>    "enabled": true,<br/>    "id": "cleanup",<br/>    "noncurrent_version_expiration_days": 90,<br/>    "prefix": "",<br/>    "transition_days": 90,<br/>    "transition_storage_class": "STANDARD_IA"<br/>  }<br/>]</pre> | no |
 | <a name="input_cluster_enabled_log_types"></a> [cluster\_enabled\_log\_types](#input\_cluster\_enabled\_log\_types) | List of desired control plane logging to enable | `list(string)` | <pre>[<br/>  "api",<br/>  "audit",<br/>  "authenticator",<br/>  "controllerManager",<br/>  "scheduler"<br/>]</pre> | no |
 | <a name="input_cluster_version"></a> [cluster\_version](#input\_cluster\_version) | Kubernetes version for the EKS cluster | `string` | `"1.32"` | no |
 | <a name="input_create_vpc"></a> [create\_vpc](#input\_create\_vpc) | Controls if VPC should be created (it affects almost all resources) | `bool` | `true` | no |

modules/storage/main.tf

@@ -49,10 +49,6 @@ resource "aws_s3_bucket_lifecycle_configuration" "materialize_storage" {
         storage_class = rule.value.transition_storage_class
       }
 
-      expiration {
-        days = rule.value.expiration_days
-      }
-
       noncurrent_version_expiration {
         noncurrent_days = rule.value.noncurrent_version_expiration_days
       }

modules/storage/variables.tf

@@ -34,7 +34,6 @@ variable "bucket_lifecycle_rules" {
     prefix                             = string
     transition_days                    = number
     transition_storage_class           = string
-    expiration_days                    = number
     noncurrent_version_expiration_days = number
   }))
 }

variables.tf

@@ -218,7 +218,6 @@ variable "bucket_lifecycle_rules" {
     prefix                             = string
     transition_days                    = number
     transition_storage_class           = string
-    expiration_days                    = number
     noncurrent_version_expiration_days = number
   }))
   default = [{
@@ -227,7 +226,6 @@ variable "bucket_lifecycle_rules" {
     prefix                             = ""
     transition_days                    = 90
     transition_storage_class           = "STANDARD_IA"
-    expiration_days                    = 365
     noncurrent_version_expiration_days = 90
   }]
 }