Fix SwapChain Creation Bug

- The size of the SwapchainImages was not being passed to the collection
  thus the collection had the correct data but the size was not
  reflecting leading to an index error when attempting to access the
  values.

Author: MathewBenson

ZEngine/ZEngine/Hardwares/VulkanDevice.cpp

@@ -1065,20 +1065,20 @@ namespace ZEngine::Hardwares
             SwapchainImageHeight = capabilities.currentExtent.height;
         }
 
-        auto                     min_image_count       = std::clamp(capabilities.minImageCount, capabilities.minImageCount + 1, capabilities.maxImageCount == 0 ? std::numeric_limits<decltype(capabilities.maxImageCount)>::max() : capabilities.maxImageCount);
+        auto                     min_image_count       = std::clamp(capabilities.minImageCount, capabilities.minImageCount, capabilities.maxImageCount == 0 ? std::numeric_limits<decltype(capabilities.maxImageCount)>::max() : capabilities.maxImageCount);
         VkSwapchainCreateInfoKHR swapchain_create_info = {
             .sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR, .pNext = nullptr, .surface = Surface, .minImageCount = min_image_count, .imageFormat = SurfaceFormat.format, .imageColorSpace = SurfaceFormat.colorSpace, .imageExtent = VkExtent2D{.width = SwapchainImageWidth, .height = SwapchainImageHeight},
                                 .imageArrayLayers = 1, .imageUsage = VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT, .preTransform = capabilities.currentTransform, .compositeAlpha = VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR, .presentMode = PresentMode, .clipped = VK_TRUE
         };
 
         if (SwapchainImageViews.capacity() <= 0)
         {
-            SwapchainImageViews.init(Arena, SwapchainImageCount, SwapchainImageCount);
+            SwapchainImageViews.init(Arena, SwapchainImageCount);
         }
 
         if (SwapchainFramebuffers.capacity() <= 0)
         {
-            SwapchainFramebuffers.init(Arena, SwapchainImageCount, SwapchainImageCount);
+            SwapchainFramebuffers.init(Arena, SwapchainImageCount);
         }
 
         auto            scratch             = ZGetScratch(Arena);
@@ -1101,7 +1101,9 @@ namespace ZEngine::Hardwares
         ZENGINE_VALIDATE_ASSERT(vkGetSwapchainImagesKHR(LogicalDevice, SwapchainHandle, &SwapchainImageCount, nullptr) == VK_SUCCESS, "Failed to get Images count from Swapchain")
 
         Array<VkImage> SwapchainImages = {};
+
         SwapchainImages.init(scratch.Arena, SwapchainImageCount, SwapchainImageCount);
+
         ZENGINE_VALIDATE_ASSERT(vkGetSwapchainImagesKHR(LogicalDevice, SwapchainHandle, &SwapchainImageCount, SwapchainImages.data()) == VK_SUCCESS, "Failed to get VkImages from Swapchain")
 
         /*Transition Image from Undefined to Present_src*/
@@ -1128,12 +1130,12 @@ namespace ZEngine::Hardwares
 
         for (int i = 0; i < SwapchainImageCount; ++i)
         {
-            SwapchainImageViews[i] = CreateImageView(SwapchainImages[i], SurfaceFormat.format, VK_IMAGE_VIEW_TYPE_2D, VK_IMAGE_ASPECT_COLOR_BIT);
+            SwapchainImageViews.push(CreateImageView(SwapchainImages[i], SurfaceFormat.format, VK_IMAGE_VIEW_TYPE_2D, VK_IMAGE_ASPECT_COLOR_BIT));
 
             Array<VkImageView> fb_images_views;
             fb_images_views.init(scratch.Arena, 1);
             fb_images_views.push(SwapchainImageViews[i]);
-            SwapchainFramebuffers[i] = CreateFramebuffer(ArrayView{fb_images_views}, SwapchainAttachment->GetHandle(), SwapchainImageWidth, SwapchainImageHeight);
+            SwapchainFramebuffers.push(CreateFramebuffer(ArrayView{fb_images_views}, SwapchainAttachment->GetHandle(), SwapchainImageWidth, SwapchainImageHeight));
         }
 
         ZReleaseScratch(scratch);

ZEngine/ZEngine/Hardwares/VulkanDevice.h

@@ -538,7 +538,7 @@ namespace ZEngine::Hardwares
         bool                                                                                HasSeperateTransfertQueueFamily            = false;
         const char*                                                                         ApplicationName                            = "Tetragrama";
         const char*                                                                         EngineName                                 = "ZEngine";
-        uint32_t                                                                            SwapchainImageCount                        = 4;
+        uint32_t                                                                            SwapchainImageCount                        = 3;
         uint32_t                                                                            SwapchainImageIndex                        = std::numeric_limits<uint8_t>::max();
         uint32_t                                                                            CurrentFrameIndex                          = std::numeric_limits<uint8_t>::max();
         uint32_t                                                                            PreviousFrameIndex                         = std::numeric_limits<uint8_t>::max();