Make flake8 clean

Author: rocky

docs/source/conf.py

@@ -13,7 +13,6 @@
 # import os
 # import sys
 # sys.path.insert(0, os.path.abspath('.'))
-import mathics_scanner
 
 # -- Project information -----------------------------------------------------
 

mathics_scanner/__init__.py

@@ -29,3 +29,22 @@
     FileLineFeeder,
     MultiLineFeeder,
 )
+
+__all__ = [
+    FileLineFeeder,
+    IncompleteSyntaxError,
+    InvalidSyntaxError,
+    LineFeeder,
+    MultiLineFeeder,
+    ScanError,
+    SingleLineFeeder,
+    Token,
+    Tokeniser,
+    TranslateError,
+    __version__,
+    aliased_characters,
+    is_symbol_name,
+    named_characters,
+    replace_unicode_with_wl,
+    replace_wl_with_plain_text,
+]

mathics_scanner/prescanner.py

@@ -80,12 +80,12 @@ def try_parse_base(self, start_shift: int, end_shift: int, base: int) -> None:
             except ValueError:
                 pass  # result remains None
         if result is None:
-            l = end - start
-            if l == 2:
+            last = end - start
+            if last == 2:
                 self.feeder.message("Syntax", "sntoct2")
-            elif l == 3:
+            elif last == 3:
                 self.feeder.message("Syntax", "sntoct1")
-            elif l == 4:
+            elif last == 4:
                 self.feeder.message("Syntax", "snthex")
             else:
                 raise ValueError()

setup.cfg

@@ -1,2 +1,50 @@
 [metadata]
 description_file = README.rst
+
+# Recommended flake8 settings while editing zoom, we use Black for the final
+# linting/say in how code is formatted
+#
+# pip install flake8 flake8-bugbear
+#
+# This will warn/error on things that black does not fix, on purpose.
+
+# This config file MUST be ASCII to prevent weird flake8 dropouts
+
+[flake8]
+# max-line-length setting: NO we do not want everyone writing 120-character lines!
+# We are setting the maximum line length big here because there are longer
+# lines allowed by black in some cases that are forbidden by flake8. Since
+# black has the final say about code formatting issues, this setting is here to
+# make sure that flake8 doesn't fail the build on longer lines allowed by
+# black.
+max-line-length = 120
+max-complexity = 12
+select = E,F,W,C,B,B9
+ignore =
+    # E123 closing bracket does not match indentation of opening bracket's line
+    E123
+    # E203 whitespace before ':' (Not PEP8 compliant, Python Black)
+    E203
+    # E501 line too long (82 > 79 characters) (replaced by B950 from flake8-bugbear,
+    # https://github.com/PyCQA/flake8-bugbear)
+    E501
+    # W503 line break before binary operator (Not PEP8 compliant, Python Black)
+    W503
+    # W504 line break after binary operator (Not PEP8 compliant, Python Black)
+    W504
+    # C901 function too complex - since many of zz9 functions are too complex with a lot
+    # of if branching
+    C901
+    # module level import not at top of file. This is too restrictive. Can't even have a
+    # docstring higher.
+    E402
+per-file-ignores =
+    # These are config files. The `c` variable them is injected not defined.
+    pow/ansible/roles/jupyterhub/templates/jupyterhub_config*.py:F821
+    # Ignore some errors in files that are stolen from other projects to avoid lots
+    # of merge problems later .
+    pow/ansible/roles/webtier/files/supervisor_httpgroupok.py:E126,E128,E222,E225,E226,E261,E301,E302,E305,F841,E201,E202
+    silhouette/src/silhouette/gprof2dot.py:E711,E713,E741,F401
+    # Ignore undefined name errors in "expectation" test Python code.
+    # These files get exec'd in an environment that defines the variables.
+    server/tests/files/expectations/*.py:F821

setup.py

@@ -46,12 +46,7 @@ def read(*rnames):
     return open(osp.join(get_srcdir(), *rnames)).read()
 
 
-# stores __version__ in the current namespace
-exec(
-    compile(
-        open("mathics_scanner/version.py").read(), "mathics_scanner/version.py", "exec"
-    )
-)
+from mathics_scanner.version import __version__
 
 # Get/set __version__ and long_description from files
 long_description = read("README.rst") + "\n"

test/test_table_consistency.py

@@ -19,12 +19,7 @@ def test_roundtrip():
     for k, v in yaml_data.items():
         if v["has-unicode-inverse"]:
             uni = v["unicode-equivalent"]
-            try:
-                wl = v["wl-unicode"]
-            except:
-                import pdb
-
-                pdb.set_trace()
+            wl = v["wl-unicode"]
             assert (
                 unicode_to_wl(wl_to_unicode(wl)) == wl
             ), f"key {k} unicode {uni}, {wl_to_unicode(uni)}"