Skip to content

CI incorrectly marks failing jobs as passing #6

@aryanjassal

Description

@aryanjassal

Describe the bug

The CI incorrectly marks a job which should have failed as completed. There is an example at https://github.com/MatrixAI/js-quic/actions/runs/15060483280/job/42334694416 where the linux job has a failed test but it does not fail the job, and it shows that it is complete.

To Reproduce

  1. Have a failing test in the jest test suite run on the CI
  2. Observe a failing test but the job passing
  3. Replicate the test failure locally to confirm the test fails

Expected behavior

If a test failed, then the job should also reflect that by failing. This does not happen.

Screenshots

Platform

  • Device: Github CI
  • OS: Linux/Nix environment

Additional context

Notify maintainers

@CMCDragonkai @brynblack

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions