Skip to content

Commit 289166a

Browse files
committed
chore: added warning for untracked directory
[ci skip]
1 parent 2a723ee commit 289166a

File tree

1 file changed

+24
-17
lines changed

1 file changed

+24
-17
lines changed

src/secrets/CommandMkdir.ts

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class CommandMkdir extends CommandPolykey {
5454
},
5555
logger: this.logger.getChild(PolykeyClient.name),
5656
});
57-
await binUtils.retryAuthentication(async (auth) => {
57+
const response = await binUtils.retryAuthentication(async (auth) => {
5858
const response =
5959
await pkClient.rpcClient.methods.vaultsSecretsMkdir();
6060
const writer = response.writable.getWriter();
@@ -69,26 +69,33 @@ class CommandMkdir extends CommandPolykey {
6969
});
7070
}
7171
await writer.close();
72-
for await (const result of response.readable) {
73-
if (result.type === 'error') {
74-
const error = result as ErrorMessage;
75-
let message: string = '';
76-
if (error.code === 'ENOENT') {
77-
message = 'No such secret or directory';
78-
} else if (error.code === 'EEXIST') {
79-
message = 'Secret or directory exists';
80-
} else {
81-
throw new ErrorPolykeyCLIUncaughtException(
82-
`Unexpected error code ${error.code}`,
83-
);
84-
}
72+
return response;
73+
}, meta);
74+
75+
// As git does not track empty directories in version control, we need
76+
// to inform the user about this.
77+
process.stderr.write(
78+
'WARNING: Empty directories will not be affected by modifications to the vault state (version change, sharing/cloning, etc.)',
79+
);
8580

86-
process.stderr.write(
87-
`${error.code}: cannot create directory ${error.reason}: ${message}`,
81+
for await (const result of response.readable) {
82+
if (result.type === 'error') {
83+
const error = result as ErrorMessage;
84+
let message: string = '';
85+
if (error.code === 'ENOENT') {
86+
message = 'No such secret or directory';
87+
} else if (error.code === 'EEXIST') {
88+
message = 'Secret or directory exists';
89+
} else {
90+
throw new ErrorPolykeyCLIUncaughtException(
91+
`Unexpected error code ${error.code}`,
8892
);
8993
}
94+
process.stderr.write(
95+
`${error.code}: cannot create directory ${error.reason}: ${message}`,
96+
);
9097
}
91-
}, meta);
98+
}
9299
} finally {
93100
if (pkClient! != null) await pkClient.stop();
94101
}

0 commit comments

Comments
 (0)