feat: removed newlines by default in secrets env command

Author: aryanjassal

src/secrets/CommandEnv.ts

@@ -22,6 +22,7 @@ class CommandEnv extends CommandPolykey {
     this.addOption(binOptions.envFormat);
     this.addOption(binOptions.envInvalid);
     this.addOption(binOptions.envDuplicate);
+    this.addOption(binOptions.preserveNewline);
     this.argument(
       '<args...>',
       'command and arguments formatted as [envPaths...][-- cmd [cmdArgs...]]',
@@ -160,7 +161,12 @@ class CommandEnv extends CommandPolykey {
                     utils.never();
                 }
               }
-              envp[newName] = secretContent;
+              // Trim the single trailing newline if it exists
+              if (secretContent.endsWith('\n')) {
+                envp[newName] = secretContent.slice(0, -1);
+              } else {
+                envp[newName] = secretContent;
+              }
               envpPath[newName] = {
                 nameOrId,
                 secretName,
@@ -175,7 +181,7 @@ class CommandEnv extends CommandPolykey {
           // Here we want to switch between the different usages
           const platform = os.platform();
           if (cmd != null) {
-            // If a cmd is| provided then we default to exec it
+            // If a cmd is provided then we default to exec it
             switch (platform) {
               case 'linux':
               // Fallthrough

src/utils/options.ts

@@ -318,6 +318,13 @@ const parents = new commander.Option(
   'If enabled, create all parent directories as well. If the directories exist, do nothing.',
 ).default(false);
 
+const preserveNewline = new commander.Option(
+  '--preserve-newline <path>',
+  'Preserve the last trailing newline for the secret content',
+)
+  .argParser(binParsers.parseSecretPathEnv)
+  .default(undefined);
+
 export {
   nodePath,
   format,
@@ -361,4 +368,5 @@ export {
   order,
   recursive,
   parents,
+  preserveNewline,
 };