chore: removed redundant tests

Author: aryanjassal

src/utils/parsers.ts

@@ -196,38 +196,6 @@ const parsePort: (data: string) => Port = validateParserToArgParser(
 const parseSeedNodes: (data: string) => [SeedNodes, boolean] =
   validateParserToArgParser(nodesUtils.parseSeedNodes);
 
-/**
- * This parses the arguments used for the env command. It should be formatted as
- * <secretPath...> [-- cmd [cmdArgs...]]
- * The cmd part of the list is separated by using `--`.
- */
-function parseEnvArgs(
-  value: string,
-  prev: [Array<ParsedSecretPathValue>, Array<string>, boolean] | undefined,
-): [Array<ParsedSecretPathValue>, Array<string>, boolean] {
-  const current: [Array<ParsedSecretPathValue>, Array<string>, boolean] =
-    prev ?? [[], [], false];
-  const [secretsList, commandList, parsingCommandCurrent] = current;
-  let parsingCommand = parsingCommandCurrent;
-  if (!parsingCommand) {
-    // Parse a secret path
-    if (value !== '--') {
-      secretsList.push(parseSecretPathEnv(value));
-    } else {
-      parsingCommand = true;
-    }
-  } else {
-    // Otherwise we just have the cmd args
-    commandList.push(value);
-  }
-  if (secretsList.length === 0 && commandList.length > 0) {
-    throw new commander.InvalidArgumentError(
-      'You must provide at least 1 secret path',
-    );
-  }
-  return [secretsList, commandList, parsingCommand];
-}
-
 export {
   vaultNameRegex,
   secretPathRegex,
@@ -256,5 +224,4 @@ export {
   parseProviderId,
   parseIdentityId,
   parseProviderIdList,
-  parseEnvArgs,
 };

tests/secrets/env.test.ts

@@ -1,5 +1,4 @@
 import type { VaultName } from 'polykey/dist/vaults/types';
-import type { ParsedSecretPathValue } from '@/types';
 import path from 'path';
 import fs from 'fs';
 import fc from 'fast-check';
@@ -9,7 +8,6 @@ import PolykeyAgent from 'polykey/dist/PolykeyAgent';
 import { vaultOps } from 'polykey/dist/vaults';
 import * as keysUtils from 'polykey/dist/keys/utils';
 import { sysexits } from 'polykey/dist/utils';
-import * as binParsers from '@/utils/parsers';
 import * as testUtils from '../utils';
 
 describe('commandEnv', () => {
@@ -865,35 +863,6 @@ describe('commandEnv', () => {
     expect(jsonOut2[secretName2]).toBe(secretContent2);
     expect(jsonOut2[secretName3]).toBe(secretContent3);
   });
-  test.prop([
-    testUtils.secretPathEnvArrayArb,
-    fc.string().noShrink(),
-    testUtils.cmdArgsArrayArb,
-  ])(
-    'parse secrets env arguments',
-    async (secretPathEnvArray, cmd, cmdArgsArray) => {
-      let output:
-        | [Array<ParsedSecretPathValue>, Array<string>, boolean]
-        | undefined = undefined;
-      // By running the parser directly, we are bypassing commander, so it works
-      // with a single --
-      const args: Array<string> = [
-        ...secretPathEnvArray,
-        '--',
-        cmd,
-        ...cmdArgsArray,
-      ];
-      for (const arg of args) {
-        output = binParsers.parseEnvArgs(arg, output);
-      }
-      const [parsedEnvs, parsedArgs] = output!;
-      const expectedSecretPathArray = secretPathEnvArray.map((v) => {
-        return binParsers.parseSecretPath(v);
-      });
-      expect(parsedEnvs).toMatchObject(expectedSecretPathArray);
-      expect(parsedArgs).toMatchObject([cmd, ...cmdArgsArray]);
-    },
-  );
   test('handles no arguments', async () => {
     const command = ['secrets', 'env', '-np', dataDir, '--env-format', 'unix'];
     const result = await testUtils.pkExec(command, {