fix: removing await from some for loops because they are not async iterables

Author: CDeltakai

src/client/handlers/VaultsList.ts

@@ -29,7 +29,7 @@ class VaultsList extends ServerHandler<
     const vaults = await db.withTransactionF((tran) =>
       vaultManager.listVaults(ctx, tran),
     );
-    for await (const [vaultName, vaultId] of vaults) {
+    for (const [vaultName, vaultId] of vaults) {
       ctx.signal.throwIfAborted();
       yield {
         vaultName: vaultName,

src/client/handlers/VaultsSecretsList.ts

@@ -66,7 +66,7 @@ class VaultsSecretsList extends ServerHandler<
           }
           throw e;
         }
-        for await (const file of files) {
+        for (const file of files) {
           ctx.signal.throwIfAborted();
           const filePath = path.join(input.secretName, file.toString());
           const stat = await fs.promises.stat(filePath);

src/keys/KeyRing.ts

@@ -60,7 +60,7 @@ class KeyRing {
     fs?: FileSystem;
     logger?: Logger;
     fresh?: boolean;
-  } & ( // eslint-disable-next-line @typescript-eslint/ban-types
+  } & (
     | {}
     | {
         recoveryCode: RecoveryCode;

src/types.ts

@@ -194,7 +194,6 @@ type InverseRecord<
  * Used when an empty object is needed.
  * Defined here with a linter override to avoid a false positive.
  */
-// eslint-disable-next-line @typescript-eslint/ban-types
 type ObjectEmpty = {};
 
 /**

src/vaults/VaultInternal.ts

@@ -1219,7 +1219,7 @@ class VaultInternal {
       dir: this.vaultDataDir,
       gitdir: this.vaultGitDir,
     });
-    for await (const [filePath, , workingDirStatus] of statusMatrix) {
+    for (const [filePath, , workingDirStatus] of statusMatrix) {
       ctx.signal.throwIfAborted();
       // Stage all changes across all files. This is needed so that we can
       // checkout all untracked files as well.