fix: refactored nodes claims get to use seek order and limit for basic pagination

Author: CDeltakai

src/nodes/NodeManager.ts

@@ -1224,7 +1224,7 @@ class NodeManager {
       const claims: Record<ClaimId, SignedClaim> = {};
       const client = connection.getClient();
       for await (const agentClaim of await client.methods.nodesClaimsGet({
-        claimIdEncoded:
+        seek:
           claimId != null
             ? claimsUtils.encodeClaimId(claimId)
             : ('' as ClaimIdEncoded),

src/nodes/agent/handlers/NodesAuditsGet.ts

@@ -9,8 +9,8 @@ import type {
   AgentAuditMessage,
 } from '../types';
 import type Audit from '../../../audit/Audit';
-import type { AuditEventIdEncoded, AuditEventId} from '../../../ids/types';
 import { ServerHandler } from '@matrixai/rpc';
+import * as auditUtils from '../../../audit/utils' 
 
 /**
  * Gets audit events from a node
@@ -46,7 +46,7 @@ class NodesAuditEventsGet extends ServerHandler<
       )) {
         ctx.signal.throwIfAborted();
         yield {
-          auditIdEncoded: auditEvent.id.toString() as AuditEventIdEncoded,
+          auditIdEncoded: auditUtils.encodeAuditEventId(auditEvent.id)
         };
       }
     });

src/nodes/agent/handlers/NodesClaimsGet.ts

@@ -5,11 +5,13 @@ import type Sigchain from '../../../sigchain/Sigchain';
 import type {
   AgentRPCRequestParams,
   AgentRPCResponseResult,
-  ClaimIdMessage,
   AgentClaimMessage,
+  NodesClaimsGetMessage,
 } from '../types';
 import { ServerHandler } from '@matrixai/rpc';
 import * as claimsUtils from '../../../claims/utils';
+import * as ids from '../../../ids';
+
 
 /**
  * Gets the sigchain claims of a node
@@ -19,21 +21,29 @@ class NodesClaimsGet extends ServerHandler<
     sigchain: Sigchain;
     db: DB;
   },
-  AgentRPCRequestParams<ClaimIdMessage>,
+  AgentRPCRequestParams<NodesClaimsGetMessage>,
   AgentRPCResponseResult<AgentClaimMessage>
 > {
   public handle = async function* (
-    _input: ClaimIdMessage,
+    input: NodesClaimsGetMessage,
     _cancel: (reason?: any) => void,
     _meta: Record<string, JSONValue> | undefined,
     ctx: ContextTimed,
   ): AsyncGenerator<AgentRPCResponseResult<AgentClaimMessage>> {
+    const { seek, order, limit } = input;
     const { sigchain, db }: { sigchain: Sigchain; db: DB } = this.container;
+
+    const decodedClaimId = ids.decodeClaimId(seek);
+
     yield* db.withTransactionG(async function* (tran): AsyncGenerator<
       AgentRPCResponseResult<AgentClaimMessage>
     > {
       for await (const [claimId, signedClaim] of sigchain.getSignedClaims(
-        { order: 'asc' },
+        { 
+          seek: decodedClaimId,
+          order: order,
+          limit: limit,
+         },
         tran,
       )) {
         ctx.signal.throwIfAborted();

src/nodes/agent/types.ts

@@ -32,10 +32,17 @@ type AuditIdMessage = {
 
 type AgentAuditMessage = Partial<AuditIdMessage> & {};
 
+type NodesClaimsGetMessage = {
+  seek?: ClaimIdEncoded | number;
+  order?: 'asc' | 'desc';
+  limit?: number;    
+}
+
 type ClaimIdMessage = {
   claimIdEncoded: ClaimIdEncoded;
 };
 
+
 type AgentClaimMessage = Partial<ClaimIdMessage> & {
   signedTokenEncoded: SignedTokenEncoded;
 };
@@ -98,6 +105,7 @@ export type {
   AgentRPCResponseResult,
   AuditIdMessage,
   AgentAuditMessage,
+  NodesClaimsGetMessage,
   ClaimIdMessage,
   AgentClaimMessage,
   NodeIdMessage,

tests/nodes/agent/handlers/nodesClaimsGet.test.ts

@@ -189,9 +189,7 @@ describe('nodesClaimsGet', () => {
       await sigchain.addClaim(identityLink);
     }
 
-    const response = await rpcClient.methods.nodesClaimsGet({
-      claimIdEncoded: '' as ClaimIdEncoded,
-    });
+    const response = await rpcClient.methods.nodesClaimsGet({});
     const chainIds: Array<string> = [];
     for await (const claim of response) {
       chainIds.push(claim.claimIdEncoded ?? '');