fix: removed unnecessary console log from utils and merged asc and desc tests for nodesClaimsGet

Author: CDeltakai

src/network/utils.ts

@@ -440,7 +440,6 @@ async function resolveHostnames(
 // TODO: review and fix the `toError` and `fromError` code here.
 //  Right now it's very basic and need fleshing out.
 function fromError(error: any) {
-  console.error(error);
   switch (typeof error) {
     case 'symbol':
     case 'bigint':

tests/nodes/agent/handlers/nodesAuditsGet.test.ts

@@ -4,6 +4,7 @@ import type Discovery from '@/discovery/Discovery';
 import fs from 'fs';
 import path from 'path';
 import os from 'os';
+import { test } from '@fast-check/jest';
 import fc from 'fast-check';
 import Logger, { LogLevel, StreamHandler } from '@matrixai/logger';
 import { QUICClient, QUICServer, events as quicEvents } from '@matrixai/quic';

tests/nodes/agent/handlers/nodesClaimsGet.test.ts

@@ -234,7 +234,7 @@ describe('nodesClaimsGet', () => {
     expect(chainIds).toHaveLength(5);
   });
 
-  test('Should get chain data with order desc', async () => {
+  test('Should get chain data with order asc and desc', async () => {
     const srcNodeIdEncoded = nodesUtils.encodeNodeId(keyRing.getNodeId());
     // Add 10 claims
     for (let i = 1; i <= 5; i++) {
@@ -260,10 +260,11 @@ describe('nodesClaimsGet', () => {
       await sigchain.addClaim(identityLink);
     }
 
-    const response = await rpcClient.methods.nodesClaimsGet({
+    // Test for descending order
+    let response = await rpcClient.methods.nodesClaimsGet({
       order: 'desc',
     });
-    const chainIds: Array<string> = [];
+    let chainIds: Array<string> = [];
     for await (const claim of response) {
       chainIds.push(claim.claimIdEncoded ?? '');
     }
@@ -277,44 +278,18 @@ describe('nodesClaimsGet', () => {
       }
     }
     expect(isSorted).toBe(true);
-  });
 
-  test('Should get chain data with order asc', async () => {
-    const srcNodeIdEncoded = nodesUtils.encodeNodeId(keyRing.getNodeId());
-    // Add 10 claims
-    for (let i = 1; i <= 5; i++) {
-      const node2 = nodesUtils.encodeNodeId(
-        testNodesUtils.generateRandomNodeId(),
-      );
-      const nodeLink = {
-        type: 'ClaimLinkNode',
-        iss: srcNodeIdEncoded,
-        sub: node2,
-      };
-      await sigchain.addClaim(nodeLink);
-    }
-    for (let i = 6; i <= 10; i++) {
-      const identityLink = {
-        type: 'ClaimLinkIdentity',
-        iss: srcNodeIdEncoded,
-        sub: encodeProviderIdentityId([
-          ('ProviderId' + i.toString()) as ProviderId,
-          ('IdentityId' + i.toString()) as IdentityId,
-        ]),
-      };
-      await sigchain.addClaim(identityLink);
-    }
-
-    const response = await rpcClient.methods.nodesClaimsGet({
+    // Test for ascending order
+    response = await rpcClient.methods.nodesClaimsGet({
       order: 'asc',
     });
-    const chainIds: Array<string> = [];
+    chainIds = [];
     for await (const claim of response) {
       chainIds.push(claim.claimIdEncoded ?? '');
     }
 
     // Verify that chainIds are in ascending order
-    let isSorted = true;
+    isSorted = true;
     for (let i = 0; i < chainIds.length - 1; i++) {
       if (chainIds[i] > chainIds[i + 1]) {
         isSorted = false;