chore: cleaned up error reporting

chore: cleaned up code

Author: aryanjassal

src/client/callers/authSignToken.ts

@@ -1,5 +1,5 @@
 import type { HandlerTypes } from '@matrixai/rpc';
-import type AuthSignToken from '../handlers/AgentLockAll.js';
+import type AuthSignToken from '../handlers/AuthSignToken.js';
 import { UnaryCaller } from '@matrixai/rpc';
 
 type CallerTypes = HandlerTypes<AuthSignToken>;

src/client/errors.ts

@@ -53,7 +53,7 @@ class ErrorClientVerificationFailed<T> extends ErrorClientService<T> {
 class ErrorAuthentication<T> extends ErrorPolykey<T> {}
 
 class ErrorAuthenticationInvalidToken<T> extends ErrorAuthentication<T> {
-  static description = 'Incoming token does not match its signature';
+  static description = 'Token is invalid';
   exitCode = sysexits.PROTOCOL;
 }
 

src/client/handlers/AuthSignToken.ts

@@ -28,11 +28,19 @@ class AuthSignToken extends UnaryHandler<
     // Get and verify incoming node
     const inputToken = { payload: input.payload, signatures: input.signatures };
     const incomingToken = Token.fromEncoded<IdentityRequestData>(inputToken);
+    if (!('publicKey' in incomingToken.payload)) {
+      throw new clientErrors.ErrorAuthenticationInvalidToken(
+        'Input token does not contain public key',
+      );
+    }
     const incomingPublicKey = Buffer.from(
       incomingToken.payload.publicKey,
+      'base64url',
     ) as PublicKey;
     if (!incomingToken.verifyWithPublicKey(incomingPublicKey)) {
-      throw new clientErrors.ErrorAuthenticationInvalidToken();
+      throw new clientErrors.ErrorAuthenticationInvalidToken(
+        'Incoming token does not match its signature',
+      );
     }
 
     // Create the outgoing token with the incoming token integrated into the

src/client/types.ts

@@ -111,7 +111,7 @@ type TokenMessage = {
 // Return URL must be present on the token, otherwise token contents is decided
 // by the client.
 type IdentityRequestData = TokenPayload & {
-  returnUrl: string;
+  returnURL: string;
   publicKey: string;
 };
 

src/network/utils.ts

@@ -477,7 +477,10 @@ function fromError(error: any) {
     // serialising only the error type, message and its stack.
     const wrappedError = new errors.ErrorPolykeyUnexpected(
       `Unexpected error occurred: ${error.name}`,
-      { cause: error },
+      {
+        cause: error,
+        data: { message: 'message' in error ? error.message : undefined },
+      },
     );
     return wrappedError.toJSON();
   }