Skip to content

Commit 76cedfb

Browse files
authored
Merge pull request #883 from MatrixAI/feature-eng-560-leaked-rpc-authentication
Fixing leaked RPC authentication error
2 parents 11972b9 + 7d4506e commit 76cedfb

26 files changed

+641
-204
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
"@matrixai/mdns": "^2.0.7",
9494
"@matrixai/quic": "^2.0.9",
9595
"@matrixai/resources": "^2.0.1",
96-
"@matrixai/rpc": "^1.0.0",
96+
"@matrixai/rpc": "^1.0.1",
9797
"@matrixai/timer": "^2.1.1",
9898
"@matrixai/workers": "^2.0.0",
9999
"@matrixai/ws": "^2.0.5",

src/nodes/NodeConnection.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -169,12 +169,9 @@ class NodeConnection {
169169
targetHostname,
170170
tlsConfig,
171171
connectionKeepAliveIntervalTime,
172-
connectionKeepAliveTimeoutTime = config.defaultsSystem
173-
.nodesConnectionIdleTimeoutTimeMin,
174-
connectionInitialMaxStreamsBidi = config.defaultsSystem
175-
.nodesConnectionInitialMaxStreamsBidi,
176-
connectionInitialMaxStreamsUni = config.defaultsSystem
177-
.nodesConnectionInitialMaxStreamsUni,
172+
connectionKeepAliveTimeoutTime,
173+
connectionInitialMaxStreamsBidi,
174+
connectionInitialMaxStreamsUni,
178175
quicSocket,
179176
manifest,
180177
logger,
@@ -301,9 +298,7 @@ class NodeConnection {
301298
const rpcClient = new RPCClient<AgentClientManifest>({
302299
manifest,
303300
middlewareFactory: rpcUtilsMiddleware.defaultClientMiddlewareWrapper(),
304-
streamFactory: async () => {
305-
return quicConnection.newStream();
306-
},
301+
streamFactory: async () => quicConnection.newStream(),
307302
toError: networkUtils.toError,
308303
logger: logger.getChild(RPCClient.name),
309304
});

0 commit comments

Comments
 (0)