tests: fixed failing ping test

The ping command handled an error and printed a different message as a result. Ping was updated to never throw an error so the distinction between the messages can no longer be made.

Author: tegefaulkes

src/bin/nodes/CommandPing.ts

@@ -19,7 +19,6 @@ class CommandPing extends CommandPolykey {
     this.action(async (nodeId: NodeId, options) => {
       const { default: PolykeyClient } = await import('../../PolykeyClient');
       const nodesUtils = await import('../../nodes/utils');
-      const nodesErrors = await import('../../nodes/errors');
       const nodesPB = await import('../../proto/js/polykey/v1/nodes/nodes_pb');
       const clientOptions = await binProcessors.processClientOptions(
         options.nodePath,
@@ -47,25 +46,11 @@ class CommandPing extends CommandPolykey {
         });
         const nodeMessage = new nodesPB.Node();
         nodeMessage.setNodeId(nodesUtils.encodeNodeId(nodeId));
-        let statusMessage;
         let error;
-        try {
-          statusMessage = await binUtils.retryAuthentication(
-            (auth) => pkClient.grpcClient.nodesPing(nodeMessage, auth),
-            meta,
-          );
-        } catch (err) {
-          if (err.cause instanceof nodesErrors.ErrorNodeGraphNodeIdNotFound) {
-            error = new binErrors.ErrorCLINodePingFailed(
-              `Failed to resolve node ID ${nodesUtils.encodeNodeId(
-                nodeId,
-              )} to an address.`,
-              { cause: err },
-            );
-          } else {
-            throw err;
-          }
-        }
+        const statusMessage = await binUtils.retryAuthentication(
+          (auth) => pkClient.grpcClient.nodesPing(nodeMessage, auth),
+          meta,
+        );
         const status = { success: false, message: '' };
         status.success = statusMessage ? statusMessage.getSuccess() : false;
         if (!status.success && !error) {

tests/bin/nodes/ping.test.ts

@@ -148,9 +148,7 @@ describe('ping', () => {
       expect(exitCode).not.toBe(0); // Should fail if node doesn't exist.
       expect(JSON.parse(stdout)).toEqual({
         success: false,
-        message: `Failed to resolve node ID ${nodesUtils.encodeNodeId(
-          fakeNodeId!,
-        )} to an address.`,
+        message: `No response received`,
       });
     },
     globalThis.failedConnectionTimeout,