fix: review fixes

Changed `Signalling` to `signaling`.

Author: tegefaulkes

src/agent/service/nodesHolePunchMessageSend.ts

@@ -71,7 +71,7 @@ function nodesHolePunchMessageSend({
               call.request.getProxyAddress(),
             );
             logger.debug(
-              `Received signalling message to target ${call.request.getSrcId()}@${host}:${port}`,
+              `Received signaling message to target ${call.request.getSrcId()}@${host}:${port}`,
             );
             // Ignore failure
             try {
@@ -81,7 +81,7 @@ function nodesHolePunchMessageSend({
             }
           } else {
             logger.error(
-              'Received signalling message, target information was missing, skipping reverse hole punch',
+              'Received signaling message, target information was missing, skipping reverse hole punch',
             );
           }
         } else if (await nodeManager.knowsNode(sourceId, tran)) {
@@ -95,19 +95,19 @@ function nodesHolePunchMessageSend({
           // Checking if the source and destination are the same
           if (sourceId?.equals(targetId)) {
             // Logging and silently dropping operation
-            logger.warn('Signalling relay message requested signal to itself');
+            logger.warn('Signaling relay message requested signal to itself');
             callback(null, response);
             return;
           }
           call.request.setProxyAddress(proxyAddress);
           logger.debug(
-            `Relaying signalling message from ${srcNodeId}@${
+            `Relaying signaling message from ${srcNodeId}@${
               connectionInfo!.remoteHost
             }:${
               connectionInfo!.remotePort
             } to ${targetNodeId} with information ${proxyAddress}`,
           );
-          await nodeConnectionManager.relaySignallingMessage(call.request, {
+          await nodeConnectionManager.relaySignalingMessage(call.request, {
             host: connectionInfo!.remoteHost,
             port: connectionInfo!.remotePort,
           });

src/nodes/NodeConnectionManager.ts

@@ -331,7 +331,7 @@ class NodeConnectionManager {
           //  It needs to timeout as well as abort for cleanup
           void Array.from(seedNodes, (seedNodeId) => {
             return (
-              this.sendSignallingMessage(
+              this.sendSignalingMessage(
                 seedNodeId,
                 this.keyManager.getNodeId(),
                 targetNodeId,
@@ -804,7 +804,7 @@ class NodeConnectionManager {
    * @param proxyAddress string of address in the form `proxyHost:proxyPort`
    * @param ctx
    */
-  public sendSignallingMessage(
+  public sendSignalingMessage(
     relayNodeId: NodeId,
     sourceNodeId: NodeId,
     targetNodeId: NodeId,
@@ -817,7 +817,7 @@ class NodeConnectionManager {
     (nodeConnectionManager: NodeConnectionManager) =>
       nodeConnectionManager.connConnectTime,
   )
-  public async sendSignallingMessage(
+  public async sendSignalingMessage(
     relayNodeId: NodeId,
     sourceNodeId: NodeId,
     targetNodeId: NodeId,
@@ -830,15 +830,15 @@ class NodeConnectionManager {
     ) {
       // Logging and silently dropping operation
       this.logger.warn(
-        'Attempted to send signalling message to our own NodeId',
+        'Attempted to send signaling message to our own NodeId',
       );
       return;
     }
     const rlyNode = nodesUtils.encodeNodeId(relayNodeId);
     const srcNode = nodesUtils.encodeNodeId(sourceNodeId);
     const tgtNode = nodesUtils.encodeNodeId(targetNodeId);
     this.logger.debug(
-      `sendSignallingMessage sending Signalling message relay: ${rlyNode}, source: ${srcNode}, target: ${tgtNode}, proxy: ${proxyAddress}`,
+      `sendSignalingMessage sending Signaling message relay: ${rlyNode}, source: ${srcNode}, target: ${tgtNode}, proxy: ${proxyAddress}`,
     );
     const relayMsg = new nodesPB.Relay();
     relayMsg.setSrcId(srcNode);
@@ -865,7 +865,7 @@ class NodeConnectionManager {
    * @param sourceAddress
    * @param ctx
    */
-  public relaySignallingMessage(
+  public relaySignalingMessage(
     message: nodesPB.Relay,
     sourceAddress: NodeAddress,
     ctx?: Partial<ContextTimed>,
@@ -876,7 +876,7 @@ class NodeConnectionManager {
     (nodeConnectionManager: NodeConnectionManager) =>
       nodeConnectionManager.connConnectTime,
   )
-  public async relaySignallingMessage(
+  public async relaySignalingMessage(
     message: nodesPB.Relay,
     sourceAddress: NodeAddress,
     @context ctx: ContextTimed,
@@ -885,7 +885,7 @@ class NodeConnectionManager {
     // If we're relaying then we trust our own node graph records over
     // what was provided in the message
     const sourceNode = validationUtils.parseNodeId(message.getSrcId());
-    await this.sendSignallingMessage(
+    await this.sendSignalingMessage(
       validationUtils.parseNodeId(message.getTargetId()),
       sourceNode,
       validationUtils.parseNodeId(message.getTargetId()),
@@ -951,7 +951,7 @@ class NodeConnectionManager {
     if (!isSeedNode) {
       void Array.from(this.getSeedNodes(), async (seedNodeId) => {
         // FIXME: this needs to handle aborting
-        void this.sendSignallingMessage(
+        void this.sendSignalingMessage(
           seedNodeId,
           this.keyManager.getNodeId(),
           nodeId,

src/nodes/NodeManager.ts

@@ -1132,7 +1132,7 @@ class NodeManager {
       )}`,
     );
     logger.info(
-      `and addresses addresses ${filteredAddresses.map(
+      `and addresses ${filteredAddresses.map(
         (address) => `${address.host}:${address.port}`,
       )}`,
     );

tests/nodes/NodeConnectionManager.general.test.ts

@@ -476,7 +476,7 @@ describe(`${NodeConnectionManager.name} general test`, () => {
       // 3. check that the relevant call was made.
       const sourceNodeId = testNodesUtils.generateRandomNodeId();
       const targetNodeId = testNodesUtils.generateRandomNodeId();
-      await nodeConnectionManager.sendSignallingMessage(
+      await nodeConnectionManager.sendSignalingMessage(
         remoteNodeId1,
         sourceNodeId,
         targetNodeId,
@@ -516,7 +516,7 @@ describe(`${NodeConnectionManager.name} general test`, () => {
       relayMessage.setSrcId(nodesUtils.encodeNodeId(sourceNodeId));
       relayMessage.setTargetId(nodesUtils.encodeNodeId(remoteNodeId1));
       relayMessage.setProxyAddress('');
-      await nodeConnectionManager.relaySignallingMessage(relayMessage, {
+      await nodeConnectionManager.relaySignalingMessage(relayMessage, {
         host: '' as Host,
         port: 0 as Port,
       });