fix: all tests now passing

Author: aryanjassal

src/nodes/NodeConnectionManager.ts

@@ -1771,14 +1771,18 @@ class NodeConnectionManager {
           );
         }
       });
+      // Gracefully close the connection if there was no error
+      await writer?.close();
+      await reader?.cancel();
       connectionsEntry.authenticatedForward = AuthenticatingState.SUCCESS;
     } catch (e) {
-      await reader?.cancel(e);
-      await writer?.abort(e);
       const err = new nodesErrors.ErrorNodeManagerAuthenticationFailed(
         undefined,
         { cause: e },
       );
+      await writer?.abort(err);
+      await reader?.cancel(err);
+      // Make sure any pending authentication is set to FAIL accordingly
       if (
         connectionsEntry.authenticatedForward === AuthenticatingState.PENDING
       ) {
@@ -1790,11 +1794,7 @@ class NodeConnectionManager {
         connectionsEntry.authenticatedReverse = AuthenticatingState.FAIL;
       }
       this.authenticateFail(targetNodeIdString, err);
-      throw err;
     }
-    // Gracefully close the connection if there was no error
-    await reader?.cancel();
-    await writer?.close();
     // Check the reverse result
     switch (connectionsEntry.authenticatedReverse) {
       case AuthenticatingState.SUCCESS:

tests/nodes/NodeManager.test.ts

@@ -76,7 +76,7 @@ describe(`${NodeManager.name}`, () => {
   const timeoutTime = 1000;
   const dummyAgentService = {
     nodesAuthenticateConnection: new DummyNodesAuthenticateConnection({}),
-  } as AgentServerManifest;
+  } as unknown as AgentServerManifest;
 
   let dataDir: string;