fix: build

Author: aryanjassal

src/nodes/NodeConnectionManager.ts

@@ -875,6 +875,11 @@ class NodeConnectionManager {
       ctx,
     );
     this.addConnection(nodeConnection.validatedNodeId, nodeConnection);
+    // TODO(aryanj): add the handshake rpc call here.
+    // TODO the handshake needs to do the following:
+    // TODO - send forward auth info
+    // TODO - parse reverse auth info
+    // TODO - success: true if match, success: false if not
     // Dispatch the connection event
     const connectionData: ConnectionData = {
       remoteNodeId: nodeConnection.nodeId,
@@ -1231,6 +1236,7 @@ class NodeConnectionManager {
    */
   @startStop.ready(new nodesErrors.ErrorNodeConnectionManagerNotRunning())
   protected handleConnectionReverse(quicConnection: QUICConnection) {
+    console.log('reverse conn')
     // Checking NodeId
     // No specific error here, validation is handled by the QUICServer
     const certChain = quicConnection.getRemoteCertsChain().map((der) => {
@@ -1282,6 +1288,7 @@ class NodeConnectionManager {
         }),
       );
     }
+    console.log('end revconn')
   }
 
   /**

src/nodes/NodeGraph.ts

@@ -14,8 +14,8 @@ import type {
 import type KeyRing from '../keys/KeyRing.js';
 import Logger from '@matrixai/logger';
 import { createDestroyStartStop } from '@matrixai/async-init';
-import { IdInternal } from '@matrixai/id';
 import { decorators } from '@matrixai/contexts';
+import { IdInternal } from '@matrixai/id';
 import * as nodesUtils from './utils.js';
 import * as nodesErrors from './errors.js';
 import * as nodesEvents from './events.js';
@@ -744,10 +744,10 @@ class NodeGraph {
     ctx?: ContextTimed,
   ): Promise<void>;
   @createDestroyStartStop.ready(new nodesErrors.ErrorNodeGraphNotRunning())
-  @timedCancellable(true)
+  @decorators.timedCancellable(true)
   public async resetBuckets(
     tran: DBTransaction | undefined,
-    @context ctx: ContextTimed,
+    @decorators.context ctx: ContextTimed,
   ): Promise<void> {
     if (tran == null) {
       return this.db.withTransactionF((tran) => this.resetBuckets(tran, ctx));

src/nodes/agent/handlers/NodesAuthenticateConnection.ts

@@ -24,6 +24,16 @@ class NodesAuthenticateConnection extends UnaryHandler<
     meta: Record<string, JSONValue> | undefined,
     ctx: ContextTimed,
   ): Promise<AgentRPCResponseResult<SuccessMessage>> => {
+    // Need to make this duplex. It will take in a forward message and parse it
+    // with the reverse handler. It will also take in another reverse auth
+    // handler from the sending node side which will parse it's forward token
+    // and see if it is authorised.
+
+    // -> forward message
+    // -> reverse handler
+    // <- success code?
+    // TODO: draw diagram to visualise this
+    
     const { nodeConnectionManager } = this.container;
     // Connections should always be validated
     const requestingNodeId = agentUtils.nodeIdFromMeta(meta);

tests/nodes/NodeConnection.test.ts

@@ -439,4 +439,16 @@ describe(`${NodeConnection.name}`, () => {
     await nodeConnectionReverse.destroy({ force: true });
     await destroyP;
   });
-});
+
+  test('asb', async () => {
+    await NodeConnection.createNodeConnection({
+      targetNodeIds: [serverNodeId],
+      targetHost: localHost as Host,
+      targetPort: quicServer.port as unknown as Port,
+      manifest: {} as AgentClientManifest,
+      tlsConfig: clientTlsConfig,
+      quicSocket: clientSocket,
+      logger: logger.getChild(`${NodeConnection.name}`),
+    }).then(extractNodeConnection);
+  });
+});

tests/nodes/NodeConnectionManager.test.ts

@@ -997,6 +997,17 @@ describe(`${NodeConnectionManager.name}`, () => {
         },
       );
     });
+    test('asb', async () => {
+      await ncmLocal.nodeConnectionManager.createConnection(
+        [ncmPeer1.nodeId],
+        localHost,
+        ncmPeer1.port,
+      );
+      // Should exist in the map now.
+      expect(
+        ncmLocal.nodeConnectionManager.hasConnection(ncmPeer1.nodeId),
+      ).toBeTrue();
+    });
   });
   describe('With 2 peers', () => {
     let ncmLocal: NCMState;