Added quality stage to sanity check release builds, also fixes package.json usage in application release

Author: CMCDragonkai

.gitignore

@@ -3,6 +3,7 @@
 .env*
 !.env.example
 /result*
+/builds
 
 # Logs
 logs

.gitlab-ci.yml

@@ -1,16 +1,18 @@
+default:
+  interruptible: true
+
 variables:
   GIT_SUBMODULE_STRATEGY: recursive
 
 stages:
   - check
   - build
+  - quality
   - release
 
-image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
-
 lint:
   stage: check
-  interruptible: true
+  image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
   script:
     - >
         nix-shell -I nixpkgs=./pkgs.nix --packages nodejs --run '
@@ -20,7 +22,7 @@ lint:
 
 test:
   stage: check
-  interruptible: true
+  image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
   script:
     - >
         nix-shell -I nixpkgs=./pkgs.nix --packages nodejs --run '
@@ -30,7 +32,7 @@ test:
 
 nix-dry:
   stage: check
-  interruptible: true
+  image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
   script:
     - nix-build -v -v --dry-run ./release.nix --attr application
     - nix-build -v -v --dry-run ./release.nix --attr docker
@@ -40,35 +42,109 @@ nix-dry:
 
 nix:
   stage: build
-  interruptible: true
+  image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
   script:
+    - mkdir -p ./builds
+    # nix-specific application target
+    - >
+        build_application="$(nix-build \
+          --max-jobs "$(nproc)" --cores "$(nproc)" \
+          ./release.nix  \
+          --attr application \
+        )"
     - >
-        nix-build ./release.nix
-        --max-jobs $(nproc)
-        --attr application
-        --attr docker
+        nix-store --export $( \
+          nix-store --query --requisites "$build_application" \
+        ) | gzip > ./builds/typescript-demo-lib.closure.gz
+    # non-nix targets
+    - >
+        builds="$(nix-build \
+          --max-jobs "$(nproc)" --cores "$(nproc)" \
+          ./release.nix \
+          --attr docker \
+          --attr package.linux.x64.elf \
+          --attr package.windows.x64.exe \
+          --attr package.macos.x64.macho)"
+    - cp -r $builds ./builds/
   only:
     - master
+  artifacts:
+    paths:
+      - ./builds/
+
+application run:
+  stage: quality
+  image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
+  dependencies:
+    - nix
+  script:
+    - >
+        build_application="$( \
+          gunzip -c ./builds/typescript-demo-lib.closure.gz | \
+          nix-store --import | \
+          tail -1 \
+        )"
+    - $build_application/bin/typescript-demo-lib
+
+docker run:
+  stage: quality
+  image: docker:20.10.11
+  dependencies:
+    - nix
+  services:
+    - docker:20.10.11-dind
+  variables:
+    DOCKER_TLS_CERTDIR: "/certs"
+  before_script:
+    - docker info
+  script:
+    - image="$(docker load --input ./builds/*docker* | cut -d' ' -f3)"
+    - docker run "$image"
+
+linux run:
+  stage: quality
+  image: ubuntu:latest
+  dependencies:
+    - nix
+  script:
+    - for f in ./builds/*-linux-*; do "$f"; done
+
+windows run:
+  stage: quality
+  dependencies:
+    - nix
+  script:
+    - Get-ChildItem -File ./builds/*-win32-* | ForEach {& $_.FullName}
+  tags:
+    - windows
+
+# macos is disabled until this repo has access
+# macos run:
+#   stage: quality
+#   image: macos-11-xcode-12
+#   dependencies:
+#     - nix
+#   script:
+#     - for f in ./builds/*-macos-*; do "$f"; done
+#   tags:
+#     - shared-macos-amd64
 
 packages:
   stage: release
-  interruptible: true
+  image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner
+  dependencies:
+    - nix
   script:
     - >
         nix-shell -I nixpkgs=./pkgs.nix --packages git gitAndTools.gh --run '
-        builds="$(nix-build \
-          --max-jobs $(nproc) --cores $(nproc) \
-          ./release.nix \
-          --attr package.linux.x64.elf \
-          --attr package.windows.x64.exe \
-          --attr package.macos.x64.macho)";
         commit="$(git rev-parse --short HEAD)";
         gh release \
-          create "$commit" $builds \
+          create "$commit" builds/*-linux-* builds/*-win32-* builds/*-macos-* \
           --title "Build-$(date -u +"%Y-%m-%dT%H:%M:%SZ")" \
           --prerelease \
           --notes "" \
           --repo MatrixAI/TypeScript-Demo-Lib;
         '
   only:
     - master
+

.npmignore

@@ -12,3 +12,4 @@
 /tmp
 /docs
 /benches
+/builds

README.md

@@ -28,7 +28,9 @@ nix-env -f ./release.nix --install --attr application
 Install into Docker:
 
 ```sh
-docker load --input "$(nix-build ./release.nix --attr docker)"
+loaded="$(docker load --input "$(nix-build ./release.nix --attr docker)")"
+image="$(cut -d' ' -f3 <<< "$loaded")"
+docker run -it "$image"
 ```
 
 ## Development

default.nix

@@ -12,7 +12,9 @@ let
     }
     ''
     mkdir -p $out/lib/node_modules/${utils.node2nixDev.packageName}
-    # copy only the dist
+    # copy the package.json
+    cp ${utils.node2nixDev}/lib/node_modules/${utils.node2nixDev.packageName}/package.json $out/lib/node_modules/${utils.node2nixDev.packageName}/
+    # copy the dist
     cp -r ${utils.node2nixDev}/lib/node_modules/${utils.node2nixDev.packageName}/dist $out/lib/node_modules/${utils.node2nixDev.packageName}/
     # copy over the production dependencies
     if [ -d "${utils.node2nixProd}/lib/node_modules" ]; then