fix: removed unreachable conditional branches

CDeltakai · CDeltakai · commit d86eceefe7e3 · 2025-05-14T15:40:01.000+10:00
diff --git a/src/RWLockReader.ts b/src/RWLockReader.ts
@@ -218,8 +218,6 @@ class RWLockReader implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';
@@ -268,8 +266,6 @@ class RWLockReader implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';
diff --git a/src/RWLockWriter.ts b/src/RWLockWriter.ts
@@ -219,8 +219,6 @@ class RWLockWriter implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';
@@ -269,8 +267,6 @@ class RWLockWriter implements Lockable {
     } else {
       if (typeof params[0] === 'string') {
         type = params.shift() as 'read' | 'write';
-      } else if (typeof params[0] == null) {
-        params.shift();
       }
     }
     type = type! ?? 'write';

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,6 @@ class RWLockReader implements Lockable {`
`218`	`218`	`} else {`
`219`	`219`	`if (typeof params[0] === 'string') {`
`220`	`220`	`type = params.shift() as 'read' \| 'write';`
`221`		`- } else if (typeof params[0] == null) {`
`222`		`- params.shift();`
`223`	`221`	`}`
`224`	`222`	`}`
`225`	`223`	`type = type! ?? 'write';`
`@@ -268,8 +266,6 @@ class RWLockReader implements Lockable {`
`268`	`266`	`} else {`
`269`	`267`	`if (typeof params[0] === 'string') {`
`270`	`268`	`type = params.shift() as 'read' \| 'write';`
`271`		`- } else if (typeof params[0] == null) {`
`272`		`- params.shift();`
`273`	`269`	`}`
`274`	`270`	`}`
`275`	`271`	`type = type! ?? 'write';`
Original file line number	Diff line number	Diff line change
`@@ -219,8 +219,6 @@ class RWLockWriter implements Lockable {`
`219`	`219`	`} else {`
`220`	`220`	`if (typeof params[0] === 'string') {`
`221`	`221`	`type = params.shift() as 'read' \| 'write';`
`222`		`- } else if (typeof params[0] == null) {`
`223`		`- params.shift();`
`224`	`222`	`}`
`225`	`223`	`}`
`226`	`224`	`type = type! ?? 'write';`
`@@ -269,8 +267,6 @@ class RWLockWriter implements Lockable {`
`269`	`267`	`} else {`
`270`	`268`	`if (typeof params[0] === 'string') {`
`271`	`269`	`type = params.shift() as 'read' \| 'write';`
`272`		`- } else if (typeof params[0] == null) {`
`273`		`- params.shift();`
`274`	`270`	`}`
`275`	`271`	`}`
`276`	`272`	`type = type! ?? 'write';`