Fix logical mode

Author: Abby010

src/bin/SpanTree.tsx

@@ -15,28 +15,47 @@ const sortSpans = (spans: Span[], mode: string): Span[] => {
   if (mode === "logical") {
     const spanMap = new Map<string, Span>();
 
-    // Convert objects to Span instances
+    // Step 1: Convert raw objects into Span instances
     spans.forEach(span => {
-      const newSpan = Object.assign(new Span(span.name, span.parentSpanId), span);
-      newSpan.children = [];
-      spanMap.set(span.spanId, newSpan);
+      if (!spanMap.has(span.spanId)) {
+        const newSpan = Object.assign(new Span(span.name, span.parentSpanId), span);
+        newSpan.children = [];
+        spanMap.set(span.spanId, newSpan);
+      }
     });
 
     const rootSpans: Span[] = [];
+
+    // Step 2: Link children correctly and prevent duplicates
     spans.forEach(span => {
       if (span.parentSpanId && spanMap.has(span.parentSpanId)) {
-        spanMap.get(span.parentSpanId)!.children.push(spanMap.get(span.spanId)!);
-      } else {
-        rootSpans.push(spanMap.get(span.spanId)!);
+        const parent = spanMap.get(span.parentSpanId);
+        const child = spanMap.get(span.spanId);
+        if (parent && child && !parent.children.includes(child)) {
+          parent.children.push(child); // ✅ Only push unique children
+        }
+      }
+    });
+
+    // Step 3: Collect only true root spans
+    spans.forEach(span => {
+      if (!span.parentSpanId) {
+        const rootSpan = spanMap.get(span.spanId);
+        if (rootSpan && !rootSpans.includes(rootSpan)) {
+          rootSpans.push(rootSpan);
+        }
       }
     });
 
-    return rootSpans;
+    return rootSpans; // ✅ Only root spans are returned, no duplicates
   } else {
+    // ✅ Sort spans by time for time-based mode
     return spans.sort((a, b) => a.startTime - b.startTime);
   }
 };
 
+
+
 /**
  * **Recursive Renderer**
  * - Uses box-drawing characters (│ ├ └) for structured layout.

src/bin/cli.tsx

@@ -6,8 +6,18 @@ import { Span } from '../lib/span.js';
 
 const SPAN_FILE = 'spans.json';
 
-// Read CLI argument for sampling mode
-const sampleMode = process.argv.includes("--sample logical") ? "logical" : "time";
+
+const sampleArgIndex = process.argv.indexOf("--sample");
+const sampleMode =
+  sampleArgIndex !== -1 && process.argv.length > sampleArgIndex + 1
+    ? process.argv[sampleArgIndex + 1].trim() === "logical"
+      ? "logical"
+      : "time"
+    : "time"; 
+
+console.log(`Received CLI arguments: ${process.argv.join(" ")}`);
+console.log(`Running in ${sampleMode} mode`);
+
 
 function loadSpans(): Span[] {
   if (!fs.existsSync(SPAN_FILE)) return [];
@@ -22,7 +32,6 @@ const App = () => {
       setSpans(loadSpans());
     }, 1000);
 
-    // ✅ Handle process termination to clean up interval
     const handleExit = () => {
       console.log("Stopping CLI...");
       clearInterval(id);