fix: updated logger level when logging errors

Errors either bubble up or are handled at some point. Decision to log them out should be made there.

IMO we should rarely use `error` level logs because errors are either caught and handled and therefor not exceptional. Or bubble to the top in which case the program crashes.

[ci skip]

Author: tegefaulkes

src/QUICClient.ts

@@ -315,19 +315,8 @@ class QUICClient {
    */
   protected handleEventQUICClientError = (evt: events.EventQUICClientError) => {
     const error = evt.detail;
-    if (
-      (error instanceof errors.ErrorQUICConnectionLocal ||
-        error instanceof errors.ErrorQUICConnectionPeer) &&
-      ((!error.data.isApp &&
-        error.data.errorCode === ConnectionErrorCode.NoError) ||
-        (error.data.isApp && error.data.errorCode === 0))
-    ) {
-      // Log out the excpetion as an info when it is graceful
-      this.logger.info(utils.formatError(error));
-    } else {
-      // Log out the exception as an error when it is not graceful
-      this.logger.error(utils.formatError(error));
-    }
+    // Log out the error
+    this.logger.info(utils.formatError(error));
     if (
       error instanceof errors.ErrorQUICClientInternal ||
       error instanceof errors.ErrorQUICConnectionInternal

src/QUICConnection.ts

@@ -181,19 +181,8 @@ class QUICConnection {
   ) => {
     const error = evt.detail;
     this.errorLast = error;
-    if (
-      (error instanceof errors.ErrorQUICConnectionLocal ||
-        error instanceof errors.ErrorQUICConnectionPeer) &&
-      ((!error.data.isApp &&
-        error.data.errorCode === ConnectionErrorCode.NoError) ||
-        (error.data.isApp && error.data.errorCode === 0))
-    ) {
-      // Log out the excpetion as an info when it is graceful
-      this.logger.info(utils.formatError(error));
-    } else {
-      // Log out the exception as an error when it is not graceful
-      this.logger.error(utils.formatError(error));
-    }
+    // Log out error for debugging
+    this.logger.info(utils.formatError(error));
     if (error instanceof errors.ErrorQUICConnectionInternal) {
       throw error;
     }

src/QUICServer.ts

@@ -72,7 +72,8 @@ class QUICServer {
    */
   protected handleEventQUICServerError = (evt: events.EventQUICServerError) => {
     const error = evt.detail;
-    this.logger.error(utils.formatError(error));
+    // Log out error for debugging
+    this.logger.info(utils.formatError(error));
     if (error instanceof errors.ErrorQUICServerInternal) {
       throw error;
     }

src/QUICSocket.ts

@@ -56,7 +56,8 @@ class QUICSocket {
 
   protected handleEventQUICSocketError = (evt: events.EventQUICSocketError) => {
     const error = evt.detail;
-    this.logger.error(utils.formatError(error));
+    // Log out error for debugging
+    this.logger.debug(utils.formatError(error));
   };
 
   protected handleEventQUICSocketClose = async () => {

src/QUICStream.ts

@@ -150,7 +150,8 @@ class QUICStream implements ReadableWritablePair<Uint8Array, Uint8Array> {
   protected handleEventQUICStreamError = (evt: events.EventQUICStreamError) => {
     const error = evt.detail;
     if (error instanceof errors.ErrorQUICStreamInternal) {
-      this.logger.error(utils.formatError(error));
+      // Log out error for debugging
+      this.logger.debug(utils.formatError(error));
       throw error;
     }
     if (

tests/QUICClient.test.ts

@@ -15,7 +15,7 @@ import * as testsUtils from './utils';
 import { generateTLSConfig, sleep } from './utils';
 
 describe(QUICClient.name, () => {
-  const logger = new Logger(`${QUICClient.name} Test`, LogLevel.SILENT, [
+  const logger = new Logger(`${QUICClient.name} Test`, LogLevel.WARN, [
     new StreamHandler(
       formatting.format`${formatting.level}:${formatting.keys}:${formatting.msg}`,
     ),

tests/QUICServer.test.ts

@@ -10,7 +10,7 @@ import * as errors from '@/errors';
 import * as testsUtils from './utils';
 
 describe(QUICServer.name, () => {
-  const logger = new Logger(`${QUICServer.name} Test`, LogLevel.SILENT, [
+  const logger = new Logger(`${QUICServer.name} Test`, LogLevel.WARN, [
     new StreamHandler(
       formatting.format`${formatting.level}:${formatting.keys}:${formatting.msg}`,
     ),

tests/QUICSocket.test.ts

@@ -13,7 +13,7 @@ import * as events from '@/events';
 import * as testsUtils from './utils';
 
 describe(QUICSocket.name, () => {
-  const logger = new Logger(`${QUICSocket.name} Test`, LogLevel.SILENT, [
+  const logger = new Logger(`${QUICSocket.name} Test`, LogLevel.WARN, [
     new StreamHandler(),
   ]);
   // This has to be setup asynchronously due to key generation
@@ -296,7 +296,7 @@ describe(QUICSocket.name, () => {
     test('error and close event lifecycle', async () => {
       // We expect error logs
       const socketLogger = logger.getChild('abc');
-      socketLogger.setLevel(LogLevel.SILENT);
+      socketLogger.setLevel(LogLevel.WARN);
       const socket = new QUICSocket({
         logger: socketLogger,
       });
@@ -865,7 +865,7 @@ describe(QUICSocket.name, () => {
         };
         // We expect lots of error logs
         const socketLogger = logger.getChild('abc');
-        socketLogger.setLevel(LogLevel.SILENT);
+        socketLogger.setLevel(LogLevel.WARN);
         const socket = new QUICSocket({
           logger: socketLogger,
         });

tests/QUICStream.test.ts

@@ -10,7 +10,7 @@ import * as testsUtils from './utils';
 import { generateTLSConfig } from './utils';
 
 describe(QUICStream.name, () => {
-  const logger = new Logger(`${QUICStream.name} Test`, LogLevel.SILENT, [
+  const logger = new Logger(`${QUICStream.name} Test`, LogLevel.WARN, [
     new StreamHandler(
       formatting.format`${formatting.level}:${formatting.keys}:${formatting.msg}`,
     ),

tests/concurrency.test.ts

@@ -12,7 +12,7 @@ import { generateTLSConfig, handleStreamProm, sleep } from './utils';
 import * as testsUtils from './utils';
 
 describe('Concurrency tests', () => {
-  const logger = new Logger(`${QUICClient.name} Test`, LogLevel.SILENT, [
+  const logger = new Logger(`${QUICClient.name} Test`, LogLevel.WARN, [
     new StreamHandler(
       formatting.format`${formatting.level}:${formatting.keys}:${formatting.msg}`,
     ),