fix: removed connection start timeout constraint

We allow for the connection start timeout to be longer than the max idle timeout of quiche. Keep in mind that the idle timeout will override the start timeout.

Author: tegefaulkes

src/QUICConnection.ts

@@ -267,12 +267,6 @@ class QUICConnection extends EventTarget {
         },
     @context ctx: ContextTimed,
   ): Promise<QUICConnection> {
-    const timeoutTime = ctx.timer.getTimeout();
-    if (timeoutTime !== Infinity && timeoutTime >= args.config.maxIdleTimeout) {
-      throw new errors.ErrorQUICConnectionInvalidConfig(
-        'connection timeout timer must be strictly less than maxIdleTimeout',
-      );
-    }
     ctx.signal.throwIfAborted();
     const abortProm = promise<never>();
     const abortHandler = () => {

tests/QUICClient.test.ts

@@ -280,62 +280,6 @@ describe(QUICClient.name, () => {
         ),
       ).rejects.toThrow(errors.ErrorQUICClientCreateTimeOut);
     });
-    test('ctx timer must be less than maxIdleTimeout', async () => {
-      // Larger timer throws
-      await expect(
-        QUICClient.createQUICClient(
-          {
-            host: localhost,
-            port: 56666,
-            localHost: localhost,
-            crypto: {
-              ops: clientCrypto,
-            },
-            logger: logger.getChild(QUICClient.name),
-            config: {
-              maxIdleTimeout: 200,
-              verifyPeer: false,
-            },
-          },
-          { timer: 1000 },
-        ),
-      ).rejects.toThrow(errors.ErrorQUICConnectionInvalidConfig);
-      // Smaller keepAliveIntervalTime doesn't cause a problem
-      await expect(
-        QUICClient.createQUICClient(
-          {
-            host: localhost,
-            port: 56666,
-            localHost: localhost,
-            crypto: {
-              ops: clientCrypto,
-            },
-            logger: logger.getChild(QUICClient.name),
-            config: {
-              maxIdleTimeout: 200,
-              verifyPeer: false,
-            },
-          },
-          { timer: 100 },
-        ),
-      ).rejects.not.toThrow(errors.ErrorQUICConnectionInvalidConfig);
-      // Not setting an interval doesn't cause a problem either
-      await expect(
-        QUICClient.createQUICClient({
-          host: localhost,
-          port: 56666,
-          localHost: localhost,
-          crypto: {
-            ops: clientCrypto,
-          },
-          logger: logger.getChild(QUICClient.name),
-          config: {
-            maxIdleTimeout: 200,
-            verifyPeer: false,
-          },
-        }),
-      ).rejects.not.toThrow(errors.ErrorQUICConnectionInvalidConfig);
-    });
     test('client times out with ctx signal while starting', async () => {
       // QUICClient repeatedly dials until the connection timeout
       const abortController = new AbortController();