Skip to content

Commit 2e11e8b

Browse files
committed
Fix a assignment method issue
Replaced attr_accessor with instance varianble
1 parent 0e30913 commit 2e11e8b

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

lib/matrixeval/ruby/command_line.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Ruby
66

77
class CommandLine
88

9-
attr_accessor :argv
9+
attr_reader :argv
1010

1111
def initialize(argv)
1212
@argv = argv
@@ -19,7 +19,7 @@ def valid?
1919
end
2020

2121
def init?
22-
argv[0] == 'init'
22+
@argv[0] == 'init'
2323
end
2424

2525
def all?
@@ -31,19 +31,19 @@ def context_options
3131
end
3232

3333
def context_arguments
34-
arguments = argv[0...seperator_index]
35-
arguments << "-h" if argv.empty?
34+
arguments = @argv[0...seperator_index]
35+
arguments << "-h" if @argv.empty?
3636
arguments
3737
end
3838

3939
def rest_arguments
40-
argv[seperator_index..-1]
40+
@argv[seperator_index..-1]
4141
end
4242

4343
private
4444

4545
def seperator_index
46-
argv.index do |argument|
46+
@argv.index do |argument|
4747
Config.commands.include?(argument)
4848
end
4949
end

lib/matrixeval/ruby/runner.rb

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ def start(argv)
1616
end
1717

1818
attr_reader :argv, :command
19-
attr_accessor :threads, :matrixeval_results
2019

2120
def initialize(argv)
2221
@argv = argv
@@ -88,7 +87,7 @@ def run_all_contexts_sequentially
8887
docker_compose = DockerCompose.new(context)
8988
success = docker_compose.run(command.rest_arguments)
9089

91-
self.matrixeval_results << [context, !!success]
90+
@matrixeval_results << [context, !!success]
9291
end
9392

9493
report
@@ -145,7 +144,7 @@ def report
145144
table.add_row headers.map { |value| { value: value, alignment: :center } }
146145
table.add_separator
147146

148-
matrixeval_results.each do |context, success|
147+
@matrixeval_results.each do |context, success|
149148
success_cell = [success ? Rainbow('Success').green : Rainbow('Failed').red]
150149
row = (context.variants.map(&:key) + success_cell).map do |value|
151150
{ value: value, alignment: :center }
@@ -160,19 +159,19 @@ def report
160159
end
161160

162161
def parallel(collection)
163-
threads = [] unless threads.empty?
164-
matrixeval_results = [] unless matrixeval_results.empty?
162+
@threads = [] unless @threads.empty?
163+
@matrixeval_results = [] unless @matrixeval_results.empty?
165164

166165
collection.each_slice(per_worker_contexts_count) do |sub_collection|
167-
threads << Thread.new do
166+
@threads << Thread.new do
168167
yield sub_collection
169168
end
170169
end
171170

172-
threads.each(&:join)
171+
@threads.each(&:join)
173172

174-
threads.each do |thread|
175-
self.matrixeval_results += (thread[:matrixeval_results] || [])
173+
@threads.each do |thread|
174+
@matrixeval_results += (thread[:matrixeval_results] || [])
176175
end
177176
end
178177

0 commit comments

Comments
 (0)