Mark MSUs as unknown if not matching MSU details

Author: MattEqualsCoder

MSURandomizerLibrary/Services/MsuCacheService.cs

@@ -6,7 +6,7 @@ namespace MSURandomizerLibrary.Services;
 
 internal class MsuCacheService : IMsuCacheService
 {
-    private const int CurrentCacheVersion = 2;
+    private const int CurrentCacheVersion = 3;
     private readonly IMsuTypeService _msuTypeService;
     private readonly MsuUserOptions _msuUserOptions;
     private readonly ILogger<MsuCacheService> _logger;

MSURandomizerLibrary/Services/MsuLookupService.cs

@@ -112,7 +112,7 @@ public IReadOnlyCollection<Msu> LookupMsus(string? defaultDirectory, Dictionary<
         {
             return null;
         }
-
+        
         var msuDetails = _msuDetailsService.GetMsuDetails(msuPath, out var yamlHash, out var yamlError);
         if (!string.IsNullOrEmpty(yamlError))
         {
@@ -121,6 +121,17 @@ public IReadOnlyCollection<Msu> LookupMsus(string? defaultDirectory, Dictionary<
 
         var baseName = Path.GetFileName(msuPath).Replace(".msu", "", StringComparison.OrdinalIgnoreCase);
         var pcmFiles = Directory.EnumerateFiles(directory, $"{baseName}-*.pcm", SearchOption.AllDirectories).ToList();
+        var msuDetailMismatch = false;
+
+        if (msuDetails?.Tracks != null && pcmFiles.Count > 0)
+        {
+            var msuDetailSongCount = msuDetails.Tracks.Values.Sum(x => 1 + (x.Alts?.Count ?? 0)) * 0.75;
+            if (pcmFiles.Count < msuDetailSongCount)
+            {
+                yamlHash = "";
+                msuDetailMismatch = true;
+            }
+        }
 
         // Load the MSU from cache if possible
         if (!ignoreCache)
@@ -130,10 +141,7 @@ public IReadOnlyCollection<Msu> LookupMsus(string? defaultDirectory, Dictionary<
             {
                 var cacheSettings = _msuUserOptions.GetMsuSettings(msuPath);
                 cacheMsu.Settings = cacheSettings;
-                if (cacheMsu.MsuType != null || cacheMsu.Settings.IsUserUnknownMsu)
-                {
-                    return cacheMsu;    
-                }
+                return cacheMsu;
             }
         }
 
@@ -153,7 +161,7 @@ public IReadOnlyCollection<Msu> LookupMsus(string? defaultDirectory, Dictionary<
         Msu msu;
 
         // If it's an unknown MSU type, simply load the details as is
-        if (msuType == null)
+        if (msuType == null || msuDetailMismatch)
         {
             msu = LoadUnknownMsu(msuPath, directory, baseName, pcmFiles);
         }