Update to show warning regarding post generation volume modifier

Author: MattEqualsCoder

MSUScripter/Configs/Settings.cs

@@ -33,6 +33,7 @@ public class Settings
     public bool TrackOverviewShowHasSongIcon { get; set; }
     public bool TrackOverviewShowCheckCopyrightIcon { get; set; }
     public bool TrackOverviewShowCopyrightSafeIcon { get; set; }
+    public bool HasShownVolumeModifierWarning { get; set; }
 
     public DefaultSongPanel DefaultSongPanel { get; set; } = DefaultSongPanel.Prompt;
 }

MSUScripter/Services/ControlServices/MsuSongPanelService.cs

@@ -20,6 +20,7 @@ public class MsuSongPanelService(
     IAudioPlayerService audioPlayerService,
     AudioAnalysisService audioAnalysisService,
     PythonCompanionService pythonCompanionService,
+    SettingsService settingsService,
     ILogger<MsuSongPanelService> logger) : ControlService
 {
     public string? GetMsuPcmInfoCopyText(MsuSongMsuPcmInfo msuPcmInfo)
@@ -289,4 +290,15 @@ public bool CanRunPyMusicLooper()
     {
         return pythonCompanionService.IsValid;
     }
+
+    public bool HasShownVolumeModifierWarning()
+    {
+        return settingsService.Settings.HasShownVolumeModifierWarning;
+    }
+
+    public void UpdateShownVolumeModifierWarning()
+    {
+        settingsService.Settings.HasShownVolumeModifierWarning = true;
+        settingsService.TrySaveSettings();
+    }
 }

MSUScripter/ViewModels/MsuSongAdvancedPanelViewModel.cs

@@ -93,6 +93,8 @@ public partial class MsuSongAdvancedPanelViewModel : SavableViewModelBase
     public event EventHandler? FileDragDropped;
 
     public MsuSongInfo? CurrentSongInfo { get; private set; }
+    public bool HasShownVolumeModifierWarning { get; set; }
+    
     private MsuSongMsuPcmInfo? _currentSongMsuPcmInfo;
     private MsuProjectWindowViewModelTreeData? _treeData;
     private MsuSongAdvancedPanelViewModelModelTreeData? _hoveredItem;

MSUScripter/Views/MsuSongAdvancedPanel.axaml

@@ -510,6 +510,7 @@
                             Grid.Column="0"
                             Margin="3 0 3 0"
                             Value="{Binding PostGenerateVolumeModifier}"
+                            LostFocus="VolumeModifierInputElement_OnLostFocus"
                         />
                         <controls:BoolComboBox 
                             Grid.Column="1" 

MSUScripter/Views/MsuSongAdvancedPanel.axaml.cs

@@ -60,6 +60,7 @@ protected override void OnLoaded(RoutedEventArgs e)
             }
 
         };
+        _viewModel.HasShownVolumeModifierWarning = Service?.HasShownVolumeModifierWarning() ?? false;
     }
 
     protected override void OnPointerMoved(PointerEventArgs e)
@@ -503,4 +504,25 @@ private void DetectEndingSamplesButton_OnClick(object? sender, RoutedEventArgs e
             // Do nothing
         }
     }
+
+    private async void VolumeModifierInputElement_OnLostFocus(object? sender, RoutedEventArgs e)
+    {
+        try
+        {
+            if (_viewModel is not { HasShownVolumeModifierWarning: false } || (_viewModel.PostGenerateVolumeModifier ?? 0) == 0)
+            {
+                return;
+            }
+
+            await MessageWindow.ShowInfoDialog(
+                "Modifying the volume here instead of the normalization option is done via the MSU Scripter rather than MsuPcm+. This means if you share the tracks.json file with others for them to generate the MSU, the volume will not match.", "Warning", TopLevel.GetTopLevel(this) as Window);
+
+            _viewModel.HasShownVolumeModifierWarning = true;
+            Service?.UpdateShownVolumeModifierWarning();
+        }
+        catch (Exception)
+        {
+            // Do nothing
+        }
+    }
 }