Finalise, type and restrict visibility

Author: VincentLanglet

src/EmailChecker/Adapter/AdapterInterface.php

@@ -25,5 +25,5 @@ interface AdapterInterface
      *
      * @return bool True for a throwaway domain
      */
-    public function isThrowawayDomain($domain);
+    public function isThrowawayDomain(string $domain): bool;
 }

src/EmailChecker/Adapter/AggregatorAdapter.php

@@ -16,24 +16,18 @@
  *
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class AggregatorAdapter implements AdapterInterface
+final class AggregatorAdapter implements AdapterInterface
 {
-    /**
-     * @var AdapterInterface[]
-     */
-    protected $adapters;
-
     /**
      * Build aggregator adapter with a list of adapters (order matters).
      *
      * @param AdapterInterface[] $adapters List of AdapterInterface objects
      */
-    public function __construct(array $adapters)
+    public function __construct(private array $adapters)
     {
-        $this->adapters = $adapters;
     }
 
-    public function isThrowawayDomain($domain)
+    public function isThrowawayDomain(string $domain): bool
     {
         foreach ($this->adapters as $adapter) {
             if ($adapter->isThrowawayDomain($domain)) {

src/EmailChecker/Adapter/AgregatorAdapter.php

@@ -16,22 +16,16 @@
  *
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class ArrayAdapter implements AdapterInterface
+final class ArrayAdapter implements AdapterInterface
 {
-    /**
-     * @var string[]
-     */
-    protected $domains;
-
     /**
      * @param string[] $domains List of throwaway domains
      */
-    public function __construct(array $domains)
+    public function __construct(private array $domains)
     {
-        $this->domains = $domains;
     }
 
-    public function isThrowawayDomain($domain)
+    public function isThrowawayDomain(string $domain): bool
     {
         return in_array($domain, $this->domains, true);
     }

src/EmailChecker/Adapter/ArrayAdapter.php

@@ -23,22 +23,22 @@
  *
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class BuiltInAdapter implements AdapterInterface
+final class BuiltInAdapter implements AdapterInterface
 {
     /**
      * @var string[]|null
      */
-    protected $domains = null;
+    protected array|null $domains = null;
 
-    public function isThrowawayDomain($domain)
+    public function isThrowawayDomain(string $domain): bool
     {
         return in_array($domain, $this->getDomains(), true);
     }
 
     /**
      * @return string[]
      */
-    private function getDomains()
+    private function getDomains(): array
     {
         if (null === $this->domains) {
             $this->domains = (new ThrowawayDomains())->toArray();

src/EmailChecker/Adapter/BuiltInAdapter.php

@@ -18,17 +18,17 @@
  *
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class FileAdapter implements AdapterInterface
+final class FileAdapter implements AdapterInterface
 {
     /**
      * @var string[]
      */
-    protected $domains;
+    protected array $domains;
 
     /**
      * @param string $filename Filename containing all domains
      */
-    public function __construct($filename)
+    public function __construct(string $filename)
     {
         $content = file_get_contents($filename);
         if (false === $content) {
@@ -38,7 +38,7 @@ public function __construct($filename)
         $this->domains = Utilities::parseLines($content);
     }
 
-    public function isThrowawayDomain($domain)
+    public function isThrowawayDomain(string $domain): bool
     {
         return in_array($domain, $this->domains, true);
     }

src/EmailChecker/Adapter/FileAdapter.php

@@ -19,19 +19,19 @@
  *
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class GaufretteAdapter implements AdapterInterface
+final class GaufretteAdapter implements AdapterInterface
 {
     /**
      * @var string[]
      */
-    protected $domains;
+    private array $domains;
 
     public function __construct(File $file)
     {
         $this->domains = Utilities::parseLines($file->getContent());
     }
 
-    public function isThrowawayDomain($domain)
+    public function isThrowawayDomain(string $domain): bool
     {
         return in_array($domain, $this->domains, true);
     }

src/EmailChecker/Adapter/GaufretteAdapter.php

@@ -19,20 +19,19 @@
  * @Annotation
  */
 #[\Attribute]
-class NotThrowawayEmail extends Constraint
+final class NotThrowawayEmail extends Constraint
 {
     /**
      * @var string
      */
     public $message = 'The domain associated with this email is not valid.';
 
     public function __construct(
-        $options = null,
-        ?array $groups = null,
-        $payload = null,
         ?string $message = null,
+        ?array $groups = null,
+        mixed $payload = null,
     ) {
-        parent::__construct($options, $groups, $payload);
+        parent::__construct(null, $groups, $payload);
 
         $this->message = $message ?? $this->message;
     }

src/EmailChecker/Constraints/NotThrowawayEmail.php

@@ -12,33 +12,23 @@
 namespace EmailChecker\Constraints;
 
 use EmailChecker\EmailChecker;
-use ReturnTypeWillChange;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintValidator;
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
 
 /**
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class NotThrowawayEmailValidator extends ConstraintValidator
+final class NotThrowawayEmailValidator extends ConstraintValidator
 {
-    /**
-     * @var EmailChecker
-     */
-    protected $emailChecker;
+    private EmailChecker $emailChecker;
 
     public function __construct(?EmailChecker $emailChecker = null)
     {
         $this->emailChecker = $emailChecker ?? new EmailChecker();
     }
 
-    /**
-     * @param mixed $value
-     *
-     * @return void
-     */
-    #[ReturnTypeWillChange]
-    public function validate($value, Constraint $constraint)
+    public function validate(mixed $value, Constraint $constraint): void
     {
         if (!$constraint instanceof NotThrowawayEmail) {
             throw new UnexpectedTypeException($constraint, NotThrowawayEmail::class);

src/EmailChecker/Constraints/NotThrowawayEmailValidator.php

@@ -20,15 +20,12 @@
  *
  * @author Matthieu Moquet <matthieu@moquet.net>
  */
-class EmailChecker
+final class EmailChecker
 {
-    /**
-     * @var AdapterInterface
-     */
-    protected $adapter;
+    private AdapterInterface $adapter;
 
     /**
-     * @param AdapterInterface $adapter Checker adapter
+     * @param AdapterInterface|null $adapter Checker adapter
      */
     public function __construct(?AdapterInterface $adapter = null)
     {
@@ -42,7 +39,7 @@ public function __construct(?AdapterInterface $adapter = null)
      *
      * @return bool true for a throwaway email
      */
-    public function isValid($email)
+    public function isValid(string $email): bool
     {
         if (false === $email = filter_var($email, FILTER_VALIDATE_EMAIL)) {
             return false;