Clean up

Author: cannc4

lib/parse-result.js

@@ -15,8 +15,6 @@ module.exports = function (options) {
       throw new errors.Forbidden('`parseI18nResult` can only be run on a `after` hook.')
     }
 
-    if (!options.language) options.language = 'en'
-
     context.result = parseResult(context.result, options.language, options.fields)
 
     return context
@@ -35,14 +33,14 @@ function parseResult (result, language, props = []) {
     return null
   }
 
-  let data = [].concat(result.data || result)
+  const data = [].concat(result.data || result)
 
   data.forEach((item, index) => {
     Object.keys(item)
       .forEach(key => {
         if (props.includes(key)) {
           // Find data of specified language, otherwise fallback to default
-          let res = data[index][key][language] || data[index][key][defaults.language]
+          const res = data[index][key][language] || data[index][key][defaults.language]
           if (res || res === '') {
             Object.assign(data[index], { [key]: res })
           }

test/parse-result.test.js

@@ -4,30 +4,6 @@ const makeHook = require('../lib/parse-result')
 const parseResult = makeHook({ fields: ['title', 'description'] })
 
 describe('Result', function () {
-  it('empty description string', function () {
-    const context = {
-      type: 'after',
-      result: {
-        data: [
-          {
-            title: {
-              en: 'another title'
-            },
-            description: {
-              en: ''
-            }
-          }
-        ]
-      }
-    }
-
-    makeHook({ fields: ['title', 'description'], language: 'en' })(context)
-    const { result } = context
-
-    assert.strictEqual(result.data[0].title, 'another title', 'we have converted the title')
-    assert.strictEqual(result.data[0].description, '', 'we have the correct description')
-  })
-
   it('transforms the result as object', function () {
     const context = {
       type: 'after',
@@ -64,8 +40,8 @@ describe('Result', function () {
 
     parseResult(context)
     const { result } = context
-    assert.strictEqual(result.data[0].title, '', 'Output not matched !!!! ??? error')
-    assert.strictEqual(result.data[0].description, '', 'Empty str')
+    assert.strictEqual(result.data[0].title, '', 'Space not parsed correctly')
+    assert.strictEqual(result.data[0].description, '', 'Space not parsed correctly')
   })
 
   it('ignores already transformed result', function () {