Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Commit 500993c

Browse files
fix(error handling): plugin swallows all errors
closes #95
1 parent 824a802 commit 500993c

File tree

11 files changed

+89
-50
lines changed

11 files changed

+89
-50
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<a href="https://travis-ci.org/MatteoGabriele/vue-analytics">
1414
<img src="https://travis-ci.org/MatteoGabriele/vue-analytics.svg?branch=master" />
1515
</a>
16-
16+
1717
<img src="https://img.shields.io/badge/size-3.07kB-brightgreen.svg" />
1818
</p>
1919

@@ -64,6 +64,8 @@ npm install vue-analytics
6464
* [E-commerce](/docs/ecommerce.md)
6565
* [Untracked hits](/docs/untracked-hits.md)
6666
* [Vuex](/docs/vuex.md)
67+
* [Turn off during development](/docs/turn-off-development.md)
68+
* [Console logs](/docs/console-logs.md)
6769
* [Debug](/docs/debug.md)
6870

6971
# Issues and features requests

SUMMARY.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,6 @@
1818
* [E-commerce](/docs/ecommerce.md)
1919
* [Untracked hits](/docs/untracked-hits.md)
2020
* [Vuex](/docs/vuex.md)
21+
* [Turn off during development](/docs/turn-off-development.md)
22+
* [Console logs](/docs/console-logs.md)
2123
* [Debug](/docs/debug.md)

__tests__/lib/autotracking.exception.spec.js

Lines changed: 0 additions & 35 deletions
This file was deleted.

__tests__/lib/exception.spec.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ window.ga = jest.fn()
66
let $vm
77

88
beforeEach(() => {
9+
Vue.config.errorHandler = jest.fn()
10+
911
Vue.use(VueAnalytics, {
1012
id: 'UA-1234-5'
1113
})

config/scripts/dev.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ const FriendyError = require('friendly-errors-webpack-plugin')
55
const pkg = require('../../package.json')
66

77
const webpackConfig = merge.smart({}, base, {
8+
devtool: 'cheap-module-eval-source-map',
89
plugins: [
910
new webpack.DefinePlugin({
1011
'process.env': {

docs/console-logs.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
## Console logs
2+
3+
Implements Google Analaytics debug logs in your console.
4+
5+
**Please remember that it is for debug only. The file size of analytics\_debug.js is way larger than analytics.js**
6+
7+
Example:
8+
9+
```js
10+
Vue.use(VueAnalytics, {
11+
id: 'UA-XXX-X',
12+
debug: {
13+
enabled: true
14+
}
15+
})
16+
```
17+
18+
Google Analytics docs: [debugging](https://developers.google.com/analytics/devguides/collection/analyticsjs/debugging)

docs/debug.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ Example:
1010
Vue.use(VueAnalytics, {
1111
id: 'UA-XXX-X',
1212
debug: {
13-
enabled: false, // default: enabled only if NODE_ENV !== 'production'
14-
trace: false, // default: false
15-
sendHitTask: false // default: enabled only if NODE_ENV === 'production'
13+
enabled: false, // default value
14+
track: false, // default value
15+
sendHitTask: true // default value
1616
}
1717
})
1818
```

docs/turn-off-development.md

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
## Turn off during development
2+
3+
Stop sending hit to your domain during development
4+
5+
Example:
6+
7+
```js
8+
Vue.use(VueAnalytics, {
9+
id: 'UA-XXX-X',
10+
debug: {
11+
sendHitTask: false
12+
}
13+
})
14+
```
15+
16+
or assign directly your NODE_ENV variable to enable/disable it automatically
17+
18+
```js
19+
Vue.use(VueAnalytics, {
20+
id: 'UA-XXX-X',
21+
debug: {
22+
sendHitTask: process.env.NODE_ENV === 'production'
23+
}
24+
})
25+
```
26+
27+
Google Analytics docs: [debugging](https://developers.google.com/analytics/devguides/collection/analyticsjs/debugging)

src/config.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ const defaultConfig = {
2424
shouldRouterUpdate: null,
2525
skipSamePath: false,
2626
exception: false,
27+
exceptionLogs: true,
2728
page: true,
2829
transformQueryString: true,
2930
pageviewOnLoad: true,
@@ -33,9 +34,9 @@ const defaultConfig = {
3334
},
3435

3536
debug: {
36-
enabled: !isProduction,
37+
enabled: false,
3738
trace: false,
38-
sendHitTask: isProduction
39+
sendHitTask: true
3940
},
4041

4142
checkDuplicatedScript: false,

src/index.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import bootstrap from './bootstrap'
22
import lib from './lib'
3-
import { errorHandler } from 'lib/exception'
43
import config, { update } from './config'
54
import { onAnalyticsReady } from './helpers'
65
import ga from 'directives/ga'
6+
import { autotracking } from 'lib/exception'
77
import analyticsMiddleware from './vuex/analyticsMiddleware'
88

99
export default function install (Vue, options = {}) {
@@ -13,9 +13,7 @@ export default function install (Vue, options = {}) {
1313

1414
Vue.prototype.$ga = Vue.$ga = lib
1515

16-
if (!Vue.config.errorHandler) {
17-
Vue.config.errorHandler = errorHandler
18-
}
16+
autotracking(Vue)
1917

2018
bootstrap()
2119
}

0 commit comments

Comments
 (0)