Skip to content

Commit 3dc2ee2

Browse files
committed
make dead-letter-queue name dynamic
1 parent 5e7cf34 commit 3dc2ee2

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

matter_task_queue/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55

66

77
from .utils import create_celery, run_task, run_task_async, async_to_sync
8-
from .celery_config import CELERY_LOW_PRIORITY_QUEUE, CELERY_DEFAULT_QUEUE, CELERY_BEAT_CONFIG, CELERY_DEAD_LETTER_QUEUE
8+
from .celery_config import CELERY_LOW_PRIORITY_QUEUE, CELERY_DEFAULT_QUEUE, CELERY_BEAT_CONFIG
99

1010
from .base_task import BaseTask

matter_task_queue/celery_config.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
CELERY_DEFAULT_QUEUE = "high_priority_queue"
1313
CELERY_LOW_PRIORITY_QUEUE = "low_priority_queue"
14-
CELERY_DEAD_LETTER_QUEUE = "dead_letter_queue"
1514

1615

1716
@after_setup_logger.connect
@@ -26,10 +25,10 @@ def get_sqs_attributes():
2625
else:
2726
sqs = boto3.client("sqs", region_name=Config.AWS_REGION)
2827

29-
response = sqs.list_queues(QueueNamePrefix=CELERY_DEAD_LETTER_QUEUE)
28+
response = sqs.list_queues(QueueNamePrefix=Config.CELERY_DEAD_LETTER_QUEUE)
3029
if len(response.get("QueueUrls", [])) == 0:
3130
response = sqs.create_queue(
32-
QueueName=CELERY_DEAD_LETTER_QUEUE,
31+
QueueName=Config.CELERY_DEAD_LETTER_QUEUE,
3332
Attributes={
3433
"DelaySeconds": "60",
3534
"MessageRetentionPeriod": "86400", # 24h Retention

matter_task_queue/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def load_variables(cls):
1515
cls.AWS_REGION = os.getenv("AWS_REGION", "eu-central-1")
1616
cls.CELERY_LOG_LEVEL = os.environ.get("CELERY_LOG_LEVEL", "INFO").upper()
1717
cls.CELERY_LOG_FILE_PATH = os.getenv("CELERY_LOG_FILE_PATH", "/tmp/celery.txt")
18+
cls.CELERY_DEAD_LETTER_QUEUE = os.getenv("CELERY_DEAD_LETTER_QUEUE", "dead_letter_queue")
1819
cls.SENTRY_DSN = os.getenv("SENTRY_DSN")
1920
cls.AWS_ENDPOINT_URL = os.getenv("AWS_ENDPOINT_URL")
2021
cls.CELERY_BROKER_URL = os.environ["CELERY_BROKER_URL"] if cls.ENV != "test" else os.getenv("CELERY_BROKER_URL")

tests/test.env

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ DEBUG=true
44
INSTANCE_NAME=observability_instance
55
CELERY_LOG_LEVEL=info
66
CELERY_LOG_FILE_PATH=/tmp/celery.txt
7+
CELERY_DEAD_LETTER_QUEUE=dead_letter_queue

0 commit comments

Comments
 (0)