Skip to content

Commit 3358d14

Browse files
committed
Add comments, bump version
1 parent 965fa9e commit 3358d14

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

duckdb_engine/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ def on_connect(self):
6262

6363
def ddl_compiler(self, dialect, ddl, **kwargs):
6464
# TODO: enforce no `serial` type
65+
66+
# duckdb doesn't support foreign key constraints (yet)
6567
ddl.include_foreign_key_constraints = {}
6668
return postgres_dialect.ddl_compiler(dialect, ddl, **kwargs)
6769

@@ -72,9 +74,11 @@ def has_table(self, connection, table_name, schema=None):
7274
return check_existance(connection, "PRAGMA show", table_name, "Table")
7375

7476
def has_sequence(self, connection, sequence_name, schema=None):
77+
# TODO: use better lookup method
7578
return check_existance(connection, "SELECT nextval", sequence_name, "Sequence")
7679

7780
def has_type(self, connection, type_name, schema=None):
81+
# duckdb doesn't support custom types
7882
return False
7983

8084
@staticmethod

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "duckdb_engine"
3-
version = "0.1.3"
3+
version = "0.1.4"
44
description = ""
55
authors = ["Elliana <me@mause.me>"]
66
license = "MIT"

0 commit comments

Comments
 (0)