Merge pull request #642 from Mause/bugfix/colspecs

fix: reuse base postgres dialect colspecs

Author: Mause

duckdb_engine/.hypothesis/examples/f024fc7dfe5f1878/7210af19145ec2a8

@@ -18,7 +18,7 @@
 from sqlalchemy import types as sqltypes
 from sqlalchemy import util
 from sqlalchemy.dialects.postgresql import UUID
-from sqlalchemy.dialects.postgresql.base import PGInspector
+from sqlalchemy.dialects.postgresql.base import PGDialect, PGInspector
 from sqlalchemy.dialects.postgresql.psycopg2 import PGDialect_psycopg2
 from sqlalchemy.engine.default import DefaultDialect
 from sqlalchemy.engine.url import URL
@@ -174,7 +174,7 @@ class Dialect(PGDialect_psycopg2):
     inspector = DuckDBInspector
     # colspecs TODO: remap types to duckdb types
     colspecs = util.update_copy(
-        PGDialect_psycopg2.colspecs,
+        PGDialect.colspecs,
         {
             # the psycopg2 driver registers a _PGNumeric with custom logic for
             # postgres type_codes (such as 701 for float) that duckdb doesn't have

duckdb_engine/.hypothesis/examples/f024fc7dfe5f1878/bec021b4f368e306

@@ -2,7 +2,7 @@
 from uuid import uuid4
 
 from pytest import importorskip, mark
-from sqlalchemy import Column, Integer, inspect
+from sqlalchemy import Column, Integer, MetaData, Table, inspect, text
 from sqlalchemy.dialects.postgresql import UUID
 from sqlalchemy.engine import Engine
 from sqlalchemy.ext.declarative import declarative_base
@@ -80,3 +80,16 @@ class Entry(base):
     result = session.query(Entry).one()
 
     assert result.id == ident
+
+
+def test_double_in_sqla_v2(engine: Engine) -> None:
+    with engine.begin() as con:
+        con.execute(text("CREATE TABLE t (x DOUBLE)"))
+        con.execute(text("INSERT INTO t VALUES (1.0), (2.0), (3.0)"))
+
+    md = MetaData()
+
+    t = Table("t", md, autoload_with=engine)
+
+    with engine.begin() as con:
+        con.execute(t.select())