Floating panel now does not spawns in settings pages after successfull traditional injection: allows to open settings fine

Author: Maxim Fomin

buttons-injection.js

@@ -78,6 +78,12 @@ function buttonBoxCheckingAndInjection(enableResiliency = true, activeWebsite) {
             // Insert custom elements (custom send buttons and toggles) into the target container.
             window.MaxExtensionButtonsInit.createAndInsertCustomElements(targetDiv);
 
+            // Mark this tab as "inline healthy" — once we have ever injected successfully,
+            // we never auto-summon the fallback panel again in this tab.
+            try {
+                window.__OCP_inlineHealthy = true;
+            } catch (_) {}
+
             // Ensure the inline selector inside does not close due to bubbling site handlers
             try {
                 const selector = targetDiv.querySelector('select');

floating-panel-ui-creation.js

@@ -63,7 +63,13 @@ window.MaxExtensionFloatingPanel.createFloatingPanel = async function () {
         this.updatePanelFromSettings();
 
         // Attach event listeners
-        closeButton.addEventListener('click', () => this.togglePanel());
+        closeButton.addEventListener('click', () => {
+            // If the user closes the panel, don’t auto-reopen it for this tab.
+            try {
+                window.__OCP_userDisabledFallback = true;
+            } catch (_) {}
+            this.togglePanel();
+        });
 
         this.makeDraggable(panel, panelHeader);
         this.makeDraggable(panel, profileSwitcherContainer);

init.js

@@ -223,7 +223,8 @@ async function commenceExtensionInitialization(configurationObject) {
     } else {
         logConCgp('[init] Decide-first: Panel is hidden. Using standard inline injection.');
         buttonBoxCheckingAndInjection(true);
-
+        // Initialize per-tab flags if absent
+        if (typeof window.__OCP_inlineHealthy === 'undefined') window.__OCP_inlineHealthy = false;
         /**
          * When inline injection fails (e.g., because the target container cannot be found),
          * there is no user click event to supply a mouse position for the floating panel.
@@ -234,18 +235,16 @@ async function commenceExtensionInitialization(configurationObject) {
         setTimeout(() => {
             try {
                 // Check if inline buttons were injected by looking for the container and its children.
-                let modsExist = false;
-                try {
+                let modsExist = (() => {
                     const containerId = window?.InjectionTargetsOnWebsite?.selectors?.buttonsContainerId;
-                    if (containerId) {
+                    if (!containerId) return false;
                         const el = document.getElementById(containerId);
-                        modsExist = !!(el && el.children && el.children.length > 0);
-                    }
-                } catch (_) {
-                    modsExist = false;
-                }
+                    return !!(el && el.children && el.children.length > 0);
+                })();
                 // Only trigger fallback if no mods exist and the panel isn’t already visible.
-                if (!modsExist && window.MaxExtensionFloatingPanel && !window.MaxExtensionFloatingPanel.isPanelVisible) {
+                const userDisabled = !!window.__OCP_userDisabledFallback;
+                if (!modsExist && !window.__OCP_inlineHealthy && !userDisabled &&
+                    window.MaxExtensionFloatingPanel && !window.MaxExtensionFloatingPanel.isPanelVisible) {
                     logConCgp("[init] We haven't found the place to inject buttons, so we will fall back to a floating panel instead.");
                     window.MaxExtensionFloatingPanel.createFloatingPanel().then(() => {
                         const panelElement = window.MaxExtensionFloatingPanel.panelElement;
@@ -267,6 +266,7 @@ async function commenceExtensionInitialization(configurationObject) {
                             panelElement.style.display = 'flex';
                             window.MaxExtensionFloatingPanel.isPanelVisible = true;
                             if (window.MaxExtensionFloatingPanel.currentPanelSettings) {
+                                // note: do not set inlineHealthy here — we are in fallback mode
                                 window.MaxExtensionFloatingPanel.currentPanelSettings.isVisible = true;
                                 window.MaxExtensionFloatingPanel.debouncedSavePanelSettings?.();
                             }