Settings button: spawned tooltip includes shortcut

Author: MaxITService

buttons-init-and-render.js

@@ -138,14 +138,13 @@ window.MaxExtensionButtonsInit = {
             } else { // 'custom' button type
                 if (def.config.text === SETTINGS_BUTTON_MAGIC_TEXT) {
                     // Special handling for the settings button.
-                    const settingsButtonConfig = { ...def.config, text: 'Settings' };
+                    const settingsButtonConfig = { ...def.config, text: 'Settings', tooltip: 'Open extension settings in a new tab' };
                     const settingsClickHandler = () => {
                        // Send a message to the service worker to open the settings page.
                        // This avoids the popup blocker (ERR_BLOCKED_BY_CLIENT).
                        chrome.runtime.sendMessage({ type: 'openSettingsPage' });
                     };
                     buttonElement = MaxExtensionButtons.createCustomSendButton(settingsButtonConfig, index, settingsClickHandler, shortcutKey);
-                    buttonElement.title = 'Open extension settings in a new tab';
                 } else {
                     buttonElement = MaxExtensionButtons.createCustomSendButton(def.config, index, processCustomSendButtonClick, shortcutKey);
                 }

buttons.js

@@ -189,8 +189,9 @@ window.MaxExtensionButtons = {
         const autoSendDescription = buttonConfig.autoSend ? ' (Auto-sends)' : '';
         const shortcutDescription = assignedShortcutKey !== null ? ` (Shortcut: Alt+${assignedShortcutKey === 10 ? 0 : assignedShortcutKey})` : '';
 
-        // Set the tooltip (title attribute) combining the button text with auto-send and shortcut info
-        customButtonElement.setAttribute('title', `${buttonConfig.text}${autoSendDescription}${shortcutDescription}`);
+        // Set the tooltip (title attribute) combining the button text (or a custom tooltip) with auto-send and shortcut info
+        const baseTooltipText = buttonConfig.tooltip || buttonConfig.text;
+        customButtonElement.setAttribute('title', `${baseTooltipText}${autoSendDescription}${shortcutDescription}`);
 
         customButtonElement.style.cssText = `
             background-color: transparent;