More makros and a rudamentary diagnose resistor implementation

Author: Max 'MaxMax' Mönikes

TLE9012.cpp

@@ -182,10 +182,21 @@ void TLE9012::wakeUp()
     (void) writeRegisterSingle(nodeID, MEAS_CTRL, 0x0080);
     mcuDelay(5);
 
+    devices[deviceID].ntc_results_valid = 0;
     for(uint8_t n = 0; n < devices[deviceID].n_temp_sensors; n++)
     {
       (void) readRegisterSingle(nodeID,EXT_TEMP0+n,&devices[deviceID].ntc_resistances[n]);
+
+      if((devices[deviceID].ntc_resistances[n]>>13)&0x01)
+      {
+        devices[deviceID].ntc_results_valid++;
+      }
     }
+
+    if(devices[deviceID].ntc_results_valid == 0)
+      devices[deviceID].ntc_results_valid = 1;
+    else
+      devices[deviceID].ntc_results_valid = 0;
 
   }
 
@@ -277,7 +288,37 @@ void TLE9012::wakeUp()
     (void) writeRegisterSingle(nodeID, AVM_CONFIG, avm_sensemask);
   }
 
- 
+/**
+ * @brief Read the internal chip temperature of internal chiptemperature sensor 1 and 2
+ * 
+ * Internal chip Temperatures are stored in the devices[] struct only if the temperatures are valid.
+ * 
+ * @param nodeID is the address of the node on the daisy chain
+ */
+  void TLE9012::readChipTemperatures(uint8_t nodeID)
+  {
+    if(nodeID > N_DEVICES)
+    {
+      return; //Early return if device number is to high
+    }
+
+    uint8_t deviceID = nodeID - 1;
+
+    if(nodeID == 0)
+      deviceID = 0;
+    else
+      deviceID = nodeID-1;
+
+    (void) readRegisterSingle(nodeID,INT_TEMP,&devices[deviceID].chiptemperature1);
+    (void) readRegisterSingle(nodeID,INT_TEMP_2,&devices[deviceID].chiptemperature2);
+
+    if(((devices[deviceID].chiptemperature1>>13)&0x01) && ((devices[deviceID].chiptemperature2>>13)&0x01))
+      devices[deviceID].chiptemperatures_valid = 1;
+    else
+      devices[deviceID].chiptemperatures_valid = 0;
+    
+  }
+
   //---------------------------------------------------------------------------
   //                       Watchdog and Powermode Functions
   //---------------------------------------------------------------------------
@@ -416,9 +457,74 @@ void TLE9012::wakeUp()
   //                       Error Checking and Handling 
   //---------------------------------------------------------------------------
 
-  void TLE9012::checkDiagnoseResistor(uint8_t nodeID)
+/**
+ * @brief Check if the Diagnosis resistor measurement is inside the expected range. This can be used in error handlers to
+ * further analyse the root cause of errors
+ * 
+ * @param nodeID is the address of the node on the daisy chain
+ * @return uint8_t returns 1 if diagnosis resistor is inside of the temperature range, 2 if no valid result is detected and 0 if
+ * the diagnosis resistance is outside of the expected range
+ */
+  uint8_t TLE9012::checkDiagnoseResistor(uint8_t nodeID)
   {
     //Not implemented yet
+    uint16_t reg_diag_r = 0;
+    (void) readRegisterSingle(nodeID, EXT_TEMP_R_DIAG, &reg_diag_r);
+    if((reg_diag_r>>13)&0x01)
+      return 2;
+    uint16_t result = reg_diag_r & 0x03FF;
+    uint8_t intc = (reg_diag_r >> 10) &0x03;
+
+    switch (intc)
+    {
+    case 3:
+      if((reg_diag_r > 218) | (reg_diag_r < 107))
+      {
+        return 1;
+      }
+      else
+      {
+        return 0;
+      }
+      break;
+
+    case 2:
+      if((reg_diag_r > 358) | (reg_diag_r < 193))
+      {
+        return 1;
+      }
+      else
+      {
+        return 0;
+      }
+      break;
+
+    case 1:
+      if((reg_diag_r > 603) | (reg_diag_r < 326))
+      {
+        return 1;
+      }
+      else
+      {
+        return 0;
+      }
+      break;
+
+    case 0:
+      if((reg_diag_r > 950) | (reg_diag_r < 595))
+      {
+        return 1;
+      }
+      else
+      {
+        return 0;
+      }
+      break;
+    
+    default:
+      break;
+    }
+
   }
 
 

TLE9012.h

@@ -50,21 +50,19 @@ const float current_source_exp_lookup[] = {1.0, 4.0, 16.0, 64.0};
 #define ADCVALUE_TO_FLOAT_VOLTAGE(value) (5.0/65536 * (float) value)
 #define NTC_MEASUREMENT_TO_R(value,r_temp_filter) ((2.0*(value&0x03FF)*current_source_exp_lookup[(value>>11)&0x03])/(1024*0.000320) - r_temp_filter)
 #define VOLTAGE_TO_OC_UC_LIMIT(voltage) ((uint16_t) ((voltage/5.0) * 1024))
+#define VOLTAGE_TO_OV_UV_LIMIT(voltage) ((uint16_t) ((voltage/5.0) * 1024))
 #define VOLTAGE_TO_OL_THRESHOLD(voltage) ((uint8_t) voltage/0.0195) //note max input voltage should not exceed ~1.2285V
 #define ADCVALUE_TO_FLOAT_BLOCKVOLTAGE(value) (60.0/65536 * (float) value)
 #define INTERNAL_IC_TEMP_TO_DEGREE(value) (-0.6624 * (float) (value & 0x3FF) + 547.3) //Kelvin/degree conversion already included?
 #define DEGREE_TO_IC_TEMP_LIMIT(degree) (((uint16_t)((degree - 547.3)/(-0.6624)))&0x3FF) //Kelvin/degree conversion already included?
 
-
 //-----------------------------------------------------------------------------
 //                          Defines for Lib functions
 //-----------------------------------------------------------------------------
 
 #define WRITECOMMAND 0x80 
 #define BROADCAST_ID 0x3F
 
-
-
 //-----------------------------------------------------------------------------
 //                          Typedefs start here
 //-----------------------------------------------------------------------------
@@ -120,12 +118,13 @@ typedef struct
 
 /** Data structure to describe properties for NTC Resistors. The current model
  *  uses a base resistance and a b value to calculate temperature following the formula
- * B*(T-TR)/(T*TR) = ln(RR/RT)
+ * T(R) = 1/((ln(R/ntc_resistance)/ntc_b_value) + (1/basetemp))
  */
 typedef struct
 {
-  float ntc_resistance;
-  float ntc_b_value;
+  float ntc_resistance; //Base Value of the NTC
+  float ntc_b_value;  //Beta value of the NTC
+  float basetemp; //Temperature of the NTC at specified resistance in Kelvin
 } ntc_config_t;
 
 /**
@@ -148,8 +147,10 @@ typedef struct
   uint16_t cell_voltages[12]; /**< Array that hold up to 12 cell voltages that can be measured */
   uint16_t block_voltage; /**< Block Voltage of the complete stack */
   uint16_t ntc_resistances[5]; /**< Measured NTC Resistance */
+  uint8_t ntc_results_valid;
   uint16_t chiptemperature1; /**< Temperature of internal Temperature Sensor Nr. 1 */
   uint16_t chiptemperature2; /**< Temperature of internal Temperature Sensor Nr. 2 */
+  uint8_t chiptemperatures_valid;
   uint16_t mailbox_register; /**< Content of the Mailbox Register */
   uint16_t scvm_high; /**< Highest value measured by the secondary measurement path */
   uint16_t scvm_low; /**< Lowest value measured by the secondary measurement path */
@@ -334,6 +335,7 @@ typedef struct
       void readTemperatures(uint8_t nodeID);
       void setNumberofCells(uint8_t nodeID, uint8_t n_cells);
       void setTempSensorsConfig(uint8_t nodeID, uint8_t n_temp_sensors,ntc_config_t sensorconfig);
+      void readChipTemperatures(uint8_t nodeID);
 
       //Watchdog and Power state handling
       void activateSleep();
@@ -349,7 +351,7 @@ typedef struct
 
 
       //Error checking and handling
-      void checkDiagnoseResistor(uint8_t nodeID);
+      uint8_t checkDiagnoseResistor(uint8_t nodeID);
       void attachErrorHandler(tle9012_error_t errortype, void (*errorhandler)(uint8_t, uint16_t));
       void checkErrors(uint8_t nodeID);
       void resetErrors(uint8_t nodeID);