Add visual mode to explorer and improve UX

Author: Maxteabag

sqlit/core/binding_contexts.py

@@ -12,6 +12,8 @@ def get_binding_contexts(ctx: InputContext) -> set[str]:
 
     if ctx.focus == "explorer":
         contexts.add("tree")
+    if ctx.tree_visual_mode_active:
+        contexts.add("tree_visual")
     if ctx.tree_filter_active:
         contexts.add("tree_filter")
 

sqlit/core/input_context.py

@@ -16,6 +16,8 @@ class InputContext:
     leader_pending: bool
     leader_menu: str
     tree_filter_active: bool
+    tree_multi_select_active: bool
+    tree_visual_mode_active: bool
     autocomplete_visible: bool
     results_filter_active: bool
     value_view_active: bool
@@ -25,6 +27,7 @@ class InputContext:
     current_connection_name: str | None
     tree_node_kind: str | None
     tree_node_connection_name: str | None
+    tree_node_connection_selected: bool
     last_result_is_error: bool
     has_results: bool
     stacked_result_count: int = 0

sqlit/core/keymap.py

@@ -292,6 +292,10 @@ def _build_action_keys(self) -> list[ActionKeyDef]:
         return [
             # Tree actions
             ActionKeyDef("n", "new_connection", "tree"),
+            ActionKeyDef("v", "enter_tree_visual_mode", "tree"),
+            ActionKeyDef("escape", "exit_tree_visual_mode", "tree_visual"),
+            ActionKeyDef("v", "exit_tree_visual_mode", "tree_visual", primary=False),
+            ActionKeyDef("escape", "clear_connection_selection", "tree"),
             ActionKeyDef("s", "select_table", "tree"),
             ActionKeyDef("f", "refresh_tree", "tree"),
             ActionKeyDef("R", "refresh_tree", "tree", primary=False),
@@ -307,7 +311,9 @@ def _build_action_keys(self) -> list[ActionKeyDef]:
             ActionKeyDef("x", "disconnect", "tree"),
             ActionKeyDef("z", "collapse_tree", "tree"),
             ActionKeyDef("j", "tree_cursor_down", "tree"),
+            ActionKeyDef("down", "tree_cursor_down", "tree", primary=False),
             ActionKeyDef("k", "tree_cursor_up", "tree"),
+            ActionKeyDef("up", "tree_cursor_up", "tree", primary=False),
             ActionKeyDef("slash", "tree_filter", "tree"),
             ActionKeyDef("escape", "tree_filter_close", "tree_filter"),
             ActionKeyDef("enter", "tree_filter_accept", "tree_filter"),

sqlit/domains/connections/app/persist_utils.py

@@ -0,0 +1,35 @@
+"""Helpers for safely persisting connections without dropping stored passwords."""
+
+from __future__ import annotations
+
+import copy
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from sqlit.domains.connections.app.credentials import CredentialsService
+    from sqlit.domains.connections.domain.config import ConnectionConfig
+
+
+def build_persist_connections(
+    connections: list[ConnectionConfig],
+    credentials_service: CredentialsService,
+) -> list[ConnectionConfig]:
+    """Return a copy of connections with missing passwords filled from storage.
+
+    This prevents saves from clearing stored passwords when the in-memory
+    connection list was loaded without credentials.
+    """
+    persist_connections = copy.deepcopy(connections)
+    for conn in persist_connections:
+        endpoint = conn.tcp_endpoint
+        if endpoint and endpoint.password is None:
+            stored = credentials_service.get_password(conn.name)
+            if stored is not None:
+                endpoint.password = stored
+
+        if conn.tunnel and conn.tunnel.password is None:
+            stored_ssh = credentials_service.get_ssh_password(conn.name)
+            if stored_ssh is not None:
+                conn.tunnel.password = stored_ssh
+
+    return persist_connections

sqlit/domains/connections/store/connections.py

@@ -189,11 +189,14 @@ def save_all(self, connections: list[ConnectionConfig]) -> None:
         Args:
             connections: List of ConnectionConfig objects to save.
         """
+        from sqlit.domains.connections.app.persist_utils import build_persist_connections
+
         errors: list[CredentialsStoreError] = []
-        for config in connections:
+        persist_connections = build_persist_connections(connections, self.credentials_service)
+        for config in persist_connections:
             errors.extend(self._save_credentials(config))
 
-        payload = [self._config_to_dict_without_passwords(c) for c in connections]
+        payload = [self._config_to_dict_without_passwords(c) for c in persist_connections]
         self._write_json(self._wrap_connections_payload(payload))
         if errors:
             raise CredentialsPersistError(errors)