fix empty password bug

Author: Maxteabag

sqlit/domains/connections/providers/mssql/adapter.py

@@ -101,6 +101,10 @@ def normalize_config(self, config: ConnectionConfig) -> ConnectionConfig:
             config.set_option("auth_type", "sql")
             config.set_option("trusted_connection", False)
 
+        auth_type = str(config.get_option("auth_type") or "sql")
+        if endpoint and endpoint.password == "" and auth_type in ("sql", "ad_password"):
+            endpoint.password = None
+
         return config
 
     def detect_capabilities(self, conn: Any, config: ConnectionConfig) -> None:

sqlit/domains/connections/ui/screens/connection.py

@@ -651,7 +651,10 @@ def _get_config(self) -> ConnectionConfig | None:
         config_data["endpoint"] = endpoint
         config_data["tunnel"] = tunnel
 
-        return ConnectionConfig.from_dict(config_data)
+        config = ConnectionConfig.from_dict(config_data)
+        from sqlit.domains.connections.providers.config_service import normalize_connection_config
+
+        return normalize_connection_config(config)
 
     def action_test_connection(self) -> None:
         from .password_input import PasswordInputScreen

tests/test_password_prompts.py

@@ -6,6 +6,7 @@
 
 from sqlit.domains.connections.cli.prompts import prompt_for_password
 from sqlit.domains.connections.domain.passwords import needs_db_password, needs_ssh_password
+from sqlit.domains.connections.providers.config_service import normalize_connection_config
 from tests.helpers import ConnectionConfig
 
 
@@ -93,6 +94,19 @@ def test_mssql_with_none_password_needs_prompt(self) -> None:
         )
         assert needs_db_password(config)
 
+    def test_mssql_empty_password_prompts_after_normalize(self) -> None:
+        """SQL Server with empty password should prompt after normalization."""
+        config = ConnectionConfig(
+            name="test",
+            db_type="mssql",
+            server="localhost",
+            username="sa",
+            password="",
+            options={"auth_type": "sql"},
+        )
+        normalized = normalize_connection_config(config)
+        assert needs_db_password(normalized)
+
     def test_mssql_windows_auth_with_none_password(self) -> None:
         """SQL Server with Windows auth doesn't need a password prompt.