Fix tests

Author: Maxteabag

tests/test_credentials_global.py

@@ -39,8 +39,15 @@ def test_reset_service(self) -> None:
 
     @patch("sqlit.domains.connections.app.credentials.KeyringCredentialsService")
     @patch("sqlit.domains.connections.app.credentials.is_keyring_usable", return_value=True)
-    def test_default_service_is_keyring(self, _mock_usable: MagicMock, mock_keyring_class: MagicMock) -> None:
-        """Test that default service is keyring-based."""
+    @patch("sqlit.domains.shell.store.settings.SettingsStore.get_instance")
+    def test_default_service_is_keyring(
+        self, mock_store_get: MagicMock, _mock_usable: MagicMock, mock_keyring_class: MagicMock
+    ) -> None:
+        """Test that default service is keyring-based when plaintext not enabled."""
+        mock_store = MagicMock()
+        mock_store.load_all.return_value = {}  # No plaintext setting
+        mock_store_get.return_value = mock_store
+
         mock_instance = MagicMock()
         mock_keyring_class.return_value = mock_instance
 
@@ -76,6 +83,20 @@ def test_plaintext_file_when_consent_recorded(
         service = get_credentials_service()
         assert isinstance(service, PlaintextFileCredentialsService)
 
+    @patch("sqlit.domains.connections.app.credentials.is_keyring_usable", return_value=True)
+    @patch("sqlit.domains.shell.store.settings.SettingsStore.get_instance")
+    def test_plaintext_takes_priority_over_keyring(
+        self, mock_store_get: MagicMock, _mock_usable: MagicMock
+    ) -> None:
+        """Test that plaintext is used when enabled, even if keyring is available."""
+        mock_store = MagicMock()
+        mock_store.load_all.return_value = {"allow_plaintext_credentials": True}
+        mock_store_get.return_value = mock_store
+        reset_credentials_service()
+        service = get_credentials_service()
+        # Should use plaintext even though keyring is usable
+        assert isinstance(service, PlaintextFileCredentialsService)
+
 
 def test_plaintext_file_credentials_service_roundtrip(tmp_path, monkeypatch):
     monkeypatch.setattr("sqlit.domains.connections.app.credentials.CONFIG_DIR", tmp_path)