Skip to content

Commit 987ece2

Browse files
committed
Improve style based on extention suggestions
Some pylint suggestions need big refactor, so it will be fix in future
1 parent fbdfcb9 commit 987ece2

File tree

7 files changed

+148
-90
lines changed

7 files changed

+148
-90
lines changed

.vscode/settings.json

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,31 @@
66
"markdownlint.config": {
77
"ol-prefix": false,
88
"no-multiple-blanks": { "maximum": 5 }
9-
}
9+
},
10+
"cSpell.words": [
11+
"GRAVATAR",
12+
"amancevice",
13+
"arey",
14+
"autopep",
15+
"datasources",
16+
"dnipro",
17+
"dtype",
18+
"executables",
19+
"healthcheck",
20+
"heca",
21+
"influxdb",
22+
"innodb",
23+
"linebreak",
24+
"markdownlint",
25+
"mbit",
26+
"mktime",
27+
"mysqladmin",
28+
"mysqld",
29+
"permalinks",
30+
"ppassword",
31+
"pylint",
32+
"strftime",
33+
"strptime",
34+
"submodules"
35+
]
1036
}

README.md

Lines changed: 40 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,50 @@
1-
eco-data-visualizer
2-
Data visualizer + AQI calculator from CSV provided by SaveEcoBot
3-
4-
# Data visualizer from SaveEcoBot. Calculate AQI.
1+
# Data visualizer from SaveEcoBot. Calculate AQI
52

63
This software up and run nice dashboard with metrics from CSV file and calculate AQI for PM2.5 and PM10
74

85
Air Quality Index calculations based on [this document](https://www.airnow.gov/sites/default/files/2018-05/aqi-technical-assistance-document-may2016.pdf)
96

10-
![](docs/en/images/first-view.png)
7+
![How it looks like](docs/en/images/first-view.png)
118

129
More screenshots and usage examples [here](docs/en/screenshots.md).
1310

1411
---
1512

16-
## MENU
17-
18-
* [Required software](#required-software-)
19-
* [Usage](#usage-)
20-
* [Quick start](#quick-start-)
21-
* [Screenshots and usage examples](docs/en/screenshots.md)
22-
* [Daily usage](#daily-usage-)
23-
* [Start](#start-)
24-
* [Stop](#stop-)
25-
* [Sensors data](#sensors-data-)
26-
* [Process new data](#process-new-data-)
27-
* [Add new data](#add-new-data-)
28-
* [Remove data](#remove-data-)
29-
* [Cleanup](#cleanup-)
30-
* [Future plans](#future-plans-)
31-
* [Want help?](#want-help-)
32-
* [License and Copyrights](#license-and-copyrights-)
33-
13+
## MENU <!-- omit in toc -->
14+
15+
* [Required software](#required-software)
16+
* [Usage](#usage)
17+
* [Quick start](#quick-start)
18+
* [Daily usage](#daily-usage)
19+
* [Start](#start)
20+
* [Stop](#stop)
21+
* [Sensors data](#sensors-data)
22+
* [Process new data](#process-new-data)
23+
* [Add new data](#add-new-data)
24+
* [Remove data](#remove-data)
25+
* [Cleanup](#cleanup)
26+
* [Future plans](#future-plans)
27+
* [Want help?](#want-help)
28+
* [License and Copyrights](#license-and-copyrights)
3429

3530
---
3631

37-
38-
## Required software [``](#menu)
32+
## Required software
3933

4034
* [`Docker`](https://docs.docker.com/get-docker/)
4135
* [`docker-compose`](https://docs.docker.com/compose/install/) (for Linux)
4236

43-
## Usage [``](#menu)
37+
## Usage
4438

45-
### Quick start [``](#menu)
39+
### Quick start
4640

4741
1. Clone this repo or [download it as zip](https://github.com/MaxymVlasov/eco-data-visualizer/archive/master.zip) and unpack.
4842

4943
2. Choose SaveEcoBot station [on this map](https://www.saveecobot.com/en/maps) and click 'Details'
50-
![](docs/en/images/map-details.png)
44+
![map-details.png](docs/en/images/map-details.png)
5145

5246
3. On bottom you'll see `Download raw data (CSV)`
53-
![](docs/en/images/download-csv.png)
47+
![download-csv.png](docs/en/images/download-csv.png)
5448
click on them and save it to `eco-data-visualizer/data/original_data/` inside download repo.
5549

5650
4. Open terminal in the root of `eco-data-visualizer` and run:
@@ -65,18 +59,19 @@ docker-compose up -d
6559
docker build -t add_influx_data ./provisioning/influx
6660
docker run -v $PWD/data/influx/:/influx-data/ --rm --network=eco-data-visualizer_default add_influx_data
6761
```
68-
62+
<!-- markdownlint-disable no-inline-html -->
6963
><sup>Depending on your internet bandwidth, CPU, Storage I/O, CSV file size and number of processed files `First Init` may take different times.
70-
For example, in laptop with `100Mbit/sec` bandwidth, `Intel Core i7-8550U` (max clock speed `4Ghz`), SSD disk and:</sup>
64+
For example, in laptop with `100Mbit/s` bandwidth, `Intel Core i7-8550U` (max clock speed `4Ghz`), SSD disk and:</sup>
7165
<sup> - 2 CSV files (together: 620MB) it takes `11m47s` (`9m39s` to transform data)</sup>
7266
<sup> - 1 CSV file (513MB) - `6m16s` (`4m18s` to transform data)</sup>
7367
<sup> - 1 CSV file (107MB) - `6m35s` (`4m32s` to transform data)</sup>
68+
<!-- markdownlint-enable no-inline-html -->
7469
7570
5. Open [http://localhost/](http://localhost/) for see visualizations!
7671

77-
### Daily usage [``](#menu)
72+
### Daily usage
7873

79-
#### Start [``](#menu)
74+
#### Start
8075

8176
For start visualization open terminal in the root of repo and run:
8277

@@ -86,17 +81,17 @@ docker-compose up -d
8681

8782
Then open [http://localhost/](http://localhost/) for see visualizations.
8883

89-
#### Stop [``](#menu)
84+
#### Stop
9085

9186
For stop visualization open terminal in the root of repo and run:
9287

9388
```bash
9489
docker-compose stop
9590
```
9691

97-
### Sensors data [``](#menu)
92+
### Sensors data
9893

99-
#### Process new data [``](#menu)
94+
#### Process new data
10095

10196
1. Download CSV file from SaveEcoBot station
10297
2. Move it to `data/original_data` folder in this repo.
@@ -109,7 +104,7 @@ docker build -t data-transformer ./data-transformer-app
109104
docker run -v $PWD/data/:/app/data/ --rm data-transformer
110105
```
111106

112-
#### Add new data [``](#menu)
107+
#### Add new data
113108

114109
For add new data open terminal in the root of repo and run:
115110

@@ -121,14 +116,14 @@ docker build -t add_influx_data ./provisioning/influx
121116
docker run -v $PWD/data/influx/:/influx-data/ --rm --network=eco-data-visualizer_default add_influx_data
122117
```
123118

124-
#### Remove data [``](#menu)
119+
#### Remove data
125120

126121
```bash
127122
docker-compose down
128123
docker volume rm eco-data-visualizer_sensors-data
129124
```
130125

131-
### Cleanup [``](#menu)
126+
### Cleanup
132127

133128
For cleanup open terminal in the root of repo and run:
134129

@@ -141,27 +136,29 @@ docker volume rm eco-data-visualizer_grafana-settings eco-data-visualizer_sensor
141136
docker run -v $PWD/data/:/app/ --rm amancevice/pandas:1.0.3-alpine sh -c "rm -f /app/csv/*.csv /app/influx/*.influx"
142137
```
143138

144-
## Future plans [``](#menu)
139+
## Future plans
145140

146141
* [ ] Add Ukrainian localization
147142
* [ ] Code and message dashboard localization
148143
* [ ] README.md localization
149144
* [ ] In Grafana Create personal graphs for each sensor with own good-bad color limits and so on as for AQI
150-
* [ ] Grab exist metrics from 'phenomenon' colum, use `SENSORS` contant only for user friendly names and localization
145+
* [ ] Grab exist metrics from 'phenomenon' colum, use `SENSORS` content only for user friendly names and localization
151146
* [ ] Add AQI support for all specified in [doc](https://www.airnow.gov/sites/default/files/2018-05/aqi-technical-assistance-document-may2016.pdf)
152147
* [ ] Optimize `data-transformer-app`
153148
* [ ] Parallel sensors operation execution
154149
* [ ] Use less Disk I/O operations
155150

156-
## Want help? [``](#menu)
151+
<!-- markdownlint-disable no-trailing-punctuation -->
152+
## Want help?
153+
<!-- markdownlint-enable no-trailing-punctuation -->
157154

158155
You can:
159156

160157
* Improve this software (see [Future plans](#future-plans-) section)
161158
* [Donate to SaveEcoBot](https://www.saveecobot.com/en/donate)
162159
* Assemble or buy Air quality monitoring station and connect it to SaveEcoBot. SaveDnipro can assemble and connect it for you. [Buy here](https://www.savednipro.org/product/stanciya-monitoringu-yakosti-povitrya/)
163160

164-
## License and Copyrights [``](#menu)
161+
## License and Copyrights
165162

166163
This software licensed by [Apache License 2.0](LICENSE)
167164

0 commit comments

Comments
 (0)