Incremental TLS handshake defragmentation tests #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-preceding-pr
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
6 tasks
gilles-peskine-arm
force-pushed
the
defragment-incremental-framework
branch
from
1c32dd8 to
27d4106
Compare
6 tasks
gilles-peskine-arm
changed the base branch from
main
to
features/tls-defragmentation
gilles-peskine-arm
added
needs-review
Signed-off-by: Gilles Peskine <[email protected]>
The symmetric encryption used for transportation matters for TLS 1.2 defragmentation, since the code is sensitive to the presence of an explicit IV. So have separate test cases for each class of symmetric encryption. Signed-off-by: Gilles Peskine <[email protected]>
In preparation for reworking mbedtls_ssl_prepare_handshake_record(), tweak the "waiting for more handshake fragments" log message in ssl_consume_current_message(), and add a similar one in mbedtls_ssl_prepare_handshake_record(). Assert both. Signed-off-by: Gilles Peskine <[email protected]>
In preparation for reworking mbedtls_ssl_prepare_handshake_record(), don't assert negatively on "reassembled record". Signed-off-by: Gilles Peskine <[email protected]>
Require the bug with defragmentation of encrypted handshake messages to be fixed. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
defragment-incremental-framework
branch
from
b703ac8 to
8d85112
Compare
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
minosgalanakis
approved these changes
Mar 6, 2025
Contributor
minosgalanakis
left a comment
minosgalanakis
left a comment
There was a problem hiding this comment.
LGTM
The CI failure is a false positive and not related to this PR
mpg
added
approved
gilles-peskine-arm
merged commit 6a7a144
into
Mbed-TLS:features/tls-defragmentation
1 of 3 checks passed
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked some tests and added a few more for Mbed-TLS/mbedtls#10011.
Status: Continues from #142. The first new commit is "Clarify test case description".
PR checklist