Skip to content

Commit abbf960

Browse files
tests: ssl: Adjust early data test
Signed-off-by: Ronald Cron <[email protected]>
1 parent 363b01f commit abbf960

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

tests/suites/test_suite_ssl.function

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@
1212

1313
#define SSL_MESSAGE_QUEUE_INIT { NULL, 0, 0, 0 }
1414

15-
#if (!defined(MBEDTLS_SSL_PROTO_TLS1_2)) && \
16-
defined(MBEDTLS_SSL_EARLY_DATA) && defined(MBEDTLS_SSL_CLI_C) && \
15+
#if defined(MBEDTLS_SSL_EARLY_DATA) && defined(MBEDTLS_SSL_CLI_C) && \
1716
defined(MBEDTLS_SSL_SRV_C) && defined(MBEDTLS_DEBUG_C) && \
1817
defined(MBEDTLS_TEST_AT_LEAST_ONE_TLS1_3_CIPHERSUITE) && \
1918
defined(MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_EPHEMERAL_ENABLED) && \
@@ -3662,12 +3661,7 @@ exit:
36623661
}
36633662
/* END_CASE */
36643663

3665-
/*
3666-
* The !MBEDTLS_SSL_PROTO_TLS1_2 dependency of tls13_early_data() below is
3667-
* a temporary workaround to not run the test in Windows-2013 where there is
3668-
* an issue with mbedtls_vsnprintf().
3669-
*/
3670-
/* BEGIN_CASE depends_on:!MBEDTLS_SSL_PROTO_TLS1_2:MBEDTLS_SSL_EARLY_DATA:MBEDTLS_SSL_CLI_C:MBEDTLS_SSL_SRV_C:MBEDTLS_DEBUG_C:MBEDTLS_TEST_AT_LEAST_ONE_TLS1_3_CIPHERSUITE:MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_EPHEMERAL_ENABLED:MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_PSK_EPHEMERAL_ENABLED:MBEDTLS_MD_CAN_SHA256:MBEDTLS_ECP_HAVE_SECP256R1:MBEDTLS_ECP_HAVE_SECP384R1:MBEDTLS_PK_CAN_ECDSA_VERIFY:MBEDTLS_SSL_SESSION_TICKETS */
3664+
/* BEGIN_CASE depends_on:MBEDTLS_SSL_EARLY_DATA:MBEDTLS_SSL_CLI_C:MBEDTLS_SSL_SRV_C:MBEDTLS_DEBUG_C:MBEDTLS_TEST_AT_LEAST_ONE_TLS1_3_CIPHERSUITE:MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_EPHEMERAL_ENABLED:MBEDTLS_SSL_TLS1_3_KEY_EXCHANGE_MODE_PSK_EPHEMERAL_ENABLED:MBEDTLS_MD_CAN_SHA256:MBEDTLS_ECP_HAVE_SECP256R1:MBEDTLS_ECP_HAVE_SECP384R1:MBEDTLS_PK_CAN_ECDSA_VERIFY:MBEDTLS_SSL_SESSION_TICKETS */
36713665
void tls13_early_data()
36723666
{
36733667
int ret = -1;
@@ -3678,7 +3672,6 @@ void tls13_early_data()
36783672
mbedtls_test_handshake_test_options client_options;
36793673
mbedtls_test_handshake_test_options server_options;
36803674
mbedtls_ssl_session saved_session;
3681-
mbedtls_test_ssl_log_pattern server_pattern = { NULL, 0 };
36823675

36833676
/*
36843677
* Test set-up
@@ -3699,9 +3692,6 @@ void tls13_early_data()
36993692
mbedtls_ssl_conf_early_data(&client_ep.conf, MBEDTLS_SSL_EARLY_DATA_ENABLED);
37003693

37013694
server_options.pk_alg = MBEDTLS_PK_ECDSA;
3702-
server_options.srv_log_fun = mbedtls_test_ssl_log_analyzer;
3703-
server_options.srv_log_obj = &server_pattern;
3704-
server_pattern.pattern = early_data;
37053695
ret = mbedtls_test_ssl_endpoint_init(&server_ep, MBEDTLS_SSL_IS_SERVER,
37063696
&server_options, NULL, NULL, NULL,
37073697
NULL);
@@ -3750,34 +3740,36 @@ void tls13_early_data()
37503740
ret = mbedtls_ssl_set_session(&(client_ep.ssl), &saved_session);
37513741
TEST_EQUAL(ret, 0);
37523742

3753-
mbedtls_debug_set_threshold(3);
3754-
37553743
TEST_EQUAL(mbedtls_test_move_handshake_to_state(
37563744
&(client_ep.ssl), &(server_ep.ssl),
37573745
MBEDTLS_SSL_SERVER_HELLO), 0);
37583746

37593747
TEST_ASSERT(client_ep.ssl.early_data_status !=
37603748
MBEDTLS_SSL_EARLY_DATA_STATUS_NOT_SENT);
3761-
TEST_EQUAL(server_pattern.counter, 0);
37623749

37633750
ret = write_early_data(&(client_ep.ssl), (unsigned char *) early_data,
37643751
early_data_len);
37653752
TEST_EQUAL(ret, early_data_len);
37663753

37673754
TEST_EQUAL(mbedtls_test_move_handshake_to_state(
37683755
&(server_ep.ssl), &(client_ep.ssl),
3769-
MBEDTLS_SSL_CLIENT_FINISHED), 0);
3756+
MBEDTLS_SSL_CLIENT_FINISHED), MBEDTLS_ERR_SSL_RECEIVED_EARLY_DATA);
37703757

37713758
TEST_EQUAL(server_ep.ssl.handshake->early_data_accepted, 1);
3772-
TEST_EQUAL(server_pattern.counter, 1);
3759+
TEST_EQUAL(mbedtls_ssl_read_early_data(&(server_ep.ssl), buf, sizeof(buf)),
3760+
early_data_len);
3761+
TEST_MEMORY_COMPARE(buf, early_data_len, early_data, early_data_len);
3762+
3763+
TEST_EQUAL(mbedtls_test_move_handshake_to_state(
3764+
&(server_ep.ssl), &(client_ep.ssl),
3765+
MBEDTLS_SSL_HANDSHAKE_OVER), 0);
37733766

37743767
exit:
37753768
mbedtls_test_ssl_endpoint_free(&client_ep, NULL);
37763769
mbedtls_test_ssl_endpoint_free(&server_ep, NULL);
37773770
mbedtls_test_free_handshake_options(&client_options);
37783771
mbedtls_test_free_handshake_options(&server_options);
37793772
mbedtls_ssl_session_free(&saved_session);
3780-
mbedtls_debug_set_threshold(0);
37813773
PSA_DONE();
37823774
}
37833775
/* END_CASE */

0 commit comments

Comments
 (0)