Skip to content

Commit b55fd70

Browse files
Merge pull request #10016 from minosgalanakis/issue9887_add_basic_defragmentation_tests_36
[3.6 Backport] Add basic handshake defragmentation tests in ssl-opt
2 parents cca140b + 5764816 commit b55fd70

File tree

3 files changed

+535
-0
lines changed

3 files changed

+535
-0
lines changed

ChangeLog.d/tls-hs-defrag-in.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,10 @@ Bugfix
33
by the spec. Lack of support was causing handshake failures with some
44
servers, especially with TLS 1.3 in practice (though both protocol
55
version could be affected in principle, and both are fixed now).
6+
The initial fragment for each handshake message must be at least 4 bytes.
7+
8+
Server-side, defragmentation of the ClientHello message is only
9+
supported if the server accepts TLS 1.3 (regardless of whether the
10+
ClientHello is 1.3 or 1.2). That is, servers configured (either
11+
at compile time or at runtime) to only accept TLS 1.2 will
12+
still fail the handshake if the ClientHello message is fragmented.

tests/scripts/analyze_outcomes.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@ def _has_word_re(words: typing.Iterable[str],
5353
# https://github.com/Mbed-TLS/mbedtls/issues/9581
5454
'Opaque key for server authentication: invalid key: decrypt with ECC key, no async',
5555
'Opaque key for server authentication: invalid key: ecdh with RSA key, no async',
56+
# Temporary disable Handshake defragmentation tests until mbedtls
57+
# pr #10011 has been merged.
58+
'Handshake defragmentation on client: len=4, TLS 1.2',
59+
'Handshake defragmentation on client: len=5, TLS 1.2',
60+
'Handshake defragmentation on client: len=13, TLS 1.2'
5661
],
5762
'test_suite_config.mbedtls_boolean': [
5863
# We never test with CBC/PKCS5/PKCS12 enabled but

0 commit comments

Comments
 (0)