Skip to content

Commit c8e4fd3

Browse files
author
Ben Taylor
committed
Initial removal of DES from mbedtls
Signed-off-by: Ben Taylor <[email protected]>
1 parent 6a9be3d commit c8e4fd3

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

tests/scripts/components-configuration-crypto.sh

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ component_test_psa_crypto_without_heap() {
9090
# is disabled below.
9191
scripts/config.py unset-all "^PSA_WANT_KEY_TYPE_RSA_"
9292
scripts/config.py unset-all "^PSA_WANT_ALG_RSA_"
93-
# DES requires built-in support for key generation (parity check) so it
94-
# cannot be accelerated
95-
scripts/config.py unset PSA_WANT_KEY_TYPE_DES
9693
# EC-JPAKE use calloc/free in PSA core
9794
scripts/config.py unset PSA_WANT_ALG_JPAKE
9895
# Enable p192[k|r]1 curves which are disabled by default in tf-psa-crypto.
@@ -330,7 +327,6 @@ component_test_full_no_cipher () {
330327
scripts/config.py unset PSA_WANT_ALG_OFB
331328
scripts/config.py unset PSA_WANT_ALG_PBKDF2_AES_CMAC_PRF_128
332329
scripts/config.py unset PSA_WANT_ALG_STREAM_CIPHER
333-
scripts/config.py unset PSA_WANT_KEY_TYPE_DES
334330

335331
# The following modules directly depends on CIPHER_C
336332
scripts/config.py unset MBEDTLS_NIST_KW_C
@@ -1709,10 +1705,6 @@ component_test_psa_crypto_config_accel_cipher_aead_cmac () {
17091705

17101706
common_psa_crypto_config_accel_cipher_aead_cmac
17111707

1712-
# Disable DES, if it still exists.
1713-
# This can be removed once we remove DES from the library.
1714-
scripts/config.py unset PSA_WANT_KEY_TYPE_DES
1715-
17161708
# Build
17171709
# -----
17181710

@@ -1749,11 +1741,8 @@ component_test_psa_crypto_config_reference_cipher_aead_cmac () {
17491741
msg "build: full config with non-accelerated cipher inc. AEAD and CMAC"
17501742
common_psa_crypto_config_accel_cipher_aead_cmac
17511743

1752-
# Disable DES, if it still exists.
1753-
# This can be removed once we remove DES from the library.
1754-
scripts/config.py unset PSA_WANT_KEY_TYPE_DES
1755-
17561744
$MAKE_COMMAND
1745+
make
17571746

17581747
msg "test: full config with non-accelerated cipher inc. AEAD and CMAC"
17591748
$MAKE_COMMAND test
@@ -2016,7 +2005,6 @@ component_build_aes_variations () {
20162005
scripts/config.py unset PSA_WANT_ALG_CBC_NO_PADDING
20172006
scripts/config.py unset PSA_WANT_ALG_CBC_PKCS7
20182007
scripts/config.py unset PSA_WANT_ALG_ECB_NO_PADDING
2019-
scripts/config.py unset PSA_WANT_KEY_TYPE_DES
20202008

20212009
build_test_config_combos ${BUILTIN_SRC_PATH}/aes.o validate_aes_config_variations \
20222010
"MBEDTLS_AES_ROM_TABLES" \
@@ -2230,7 +2218,6 @@ config_block_cipher_no_decrypt () {
22302218
scripts/config.py unset PSA_WANT_ALG_CBC_NO_PADDING
22312219
scripts/config.py unset PSA_WANT_ALG_CBC_PKCS7
22322220
scripts/config.py unset PSA_WANT_ALG_ECB_NO_PADDING
2233-
scripts/config.py unset PSA_WANT_KEY_TYPE_DES
22342221
}
22352222

22362223
component_test_block_cipher_no_decrypt_aesni () {

tests/scripts/depends.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -324,10 +324,6 @@ def test(self, options):
324324
'-PSA_WANT_ALG_CCM',
325325
'-PSA_WANT_ALG_GCM',
326326
'-PSA_WANT_ALG_ECB_NO_PADDING'],
327-
'PSA_WANT_KEY_TYPE_DES': ['-PSA_WANT_ALG_CCM',
328-
'-PSA_WANT_ALG_GCM',
329-
'-MBEDTLS_SSL_TICKET_C',
330-
'-MBEDTLS_SSL_CONTEXT_SERIALIZATION'],
331327
}
332328
def handle_exclusive_groups(config_settings, symbol):
333329
"""For every symbol tested in an exclusive group check if there are other

tests/scripts/set_psa_test_dependencies.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
'MBEDTLS_CHACHAPOLY_C',
5454
'MBEDTLS_CMAC_C',
5555
'MBEDTLS_CTR_DRBG_C',
56-
'MBEDTLS_DES_C',
5756
'MBEDTLS_ECDH_C',
5857
'MBEDTLS_ECDSA_C',
5958
'MBEDTLS_ECJPAKE_C',

0 commit comments

Comments
 (0)