Skip to content

Crypto generated files use inconsistent copies of the framework in Mbed TLS #10529

@gilles-peskine-arm

Description

@gilles-peskine-arm

On development since before 4.0.0 and as of caaa938, some generated files under tf-psa-crypto are generated via Mbed TLS's copy of the framework when building with make, but with TF-PSA-Crypto's copy when running tf-psa-crypto/framework/scripts/make_generated_files.py or CMake. This inconsistency can bite when the two copies of the framework are out of synch.

For example, in https://ci.trustedfirmware.org/job/mbed-tls-pr-head/job/PR-10507-head/7/ , result analysis failed because the framework differences caused some test cases to be emitted or not depending on whether make or CMake was used, which resulted in complaints from the driver-vs-reference checks.

We tried to catch this in all.sh check_generated_files, and we have the right check in place, but it didn't cause a CI failure because of Mbed-TLS/mbedtls-framework#244.

Metadata

Metadata

Labels

bugcomponent-platformPortability layer and build scriptssize-xsEstimated task size: extra small (a few hours at most)

Type

Projects

Status

In Progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions