Skip to content

Conversation

dc6jgk
Copy link

@dc6jgk dc6jgk commented Aug 25, 2025

Description

allow negotiation of all use_srtp profile values currently listed by IANA, especially the AEAD modes from RFC7714(which all browsers already support for WebRTC)

PR checklist

  • changelog provided
  • development PR provided
  • TF-PSA-Crypto PR not required because: No changes
  • framework PR not required
  • 3.6 PR not required because: Not breaking any APIs
  • tests provided (but these are completely blind changes matching existing test patterns, unable to run/execute any of these due to local build-system limitations/changes)

Gero Kuehn added 5 commits August 25, 2025 15:23
…IANA, especially the AEAD modes from RFC7714(which all browsers already support for WebRTC)

Signed-off-by: Gero Kuehn <[email protected]>
…se_srtp profile values currently listed by IANA, added MBEDTLS_TLS_SRTP_AEAD_AES_128_GCM/MBEDTLS_TLS_SRTP_AEAD_AES_256_GCM to default_profiles

Signed-off-by: Gero Kuehn <[email protected]>
Signed-off-by: Gero Kuehn <[email protected]>
@dc6jgk
Copy link
Author

dc6jgk commented Sep 19, 2025

If anyone is reading this: I have no idea how to retroactively apply the "review required" label here. Is there anything left I can or am supposed to do here?

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Sep 19, 2025
@gilles-peskine-arm
Copy link
Contributor

I've gone and applied the labels (you need to have the reviewer privilege to apply labels).

I'm afraid it might take a while for us to review this because we have a huge backlog.

I've also started a CI run. Note that due the ramp-up to the 4.0 release next month, we have made a lot of incompatible changes lately, so you may run into unrelated failures. If so, rebasing on top of development will help. But there's no urgency in rebasing since it will take a while before we can review.

@dc6jgk
Copy link
Author

dc6jgk commented Sep 19, 2025

Thanks. Unless someone else tried doing exactly the same thing, I doubt that this addition causes any conflicts but I will have a look at what changes in the development branch from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component-tls needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-s Estimated task size: small (~2d)

Projects

Status: No status
Status: In Development

Development

Successfully merging this pull request may close these issues.

2 participants