Add TLS 1.3 ticket and early data unit tests #8711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronald-cron-arm
added
enhancement
needs-ci
ronald-cron-arm
force-pushed
the
tls13-ticket-and-early-data-unit-test
branch
9 times, most recently
from
5bb025c to
6588011
Compare
Fix setting of early data transform when we do not send dummy CCS for middlebox compatibility. Signed-off-by: Ronald Cron <[email protected]>
Add ticket write/parse test functions as defined by mbedtls_ssl_ticket_write/parse_t. They are intended to be used in negative testing involving tickets. Signed-off-by: Ronald Cron <[email protected]>
This aims to provide a basis for negative testing around TLS 1.3 ticket, replacing eventually the negative tests done in ssl-opt.sh using the dummy_ticket option. Signed-off-by: Ronald Cron <[email protected]>
Move the setting of the debug callback to the endpoint initialization function. That way, no need to repeat it in various testing scenarios. Signed-off-by: Ronald Cron <[email protected]>
This aims to provide a basis for negative testing around TLS 1.3 early data. Signed-off-by: Ronald Cron <[email protected]>
Temporary workaround to not run the early data test in Windows-2013 where there is an issue with mbedtls_vsnprintf(). Signed-off-by: Ronald Cron <[email protected]>
ronald-cron-arm
force-pushed
the
tls13-ticket-and-early-data-unit-test
branch
from
6588011 to
f8fdbb5
Compare
3 tasks
ronald-cron-arm
added
needs-review
This was referenced Jan 26, 2024
tom-cosgrove-arm
added
priority-very-high
mpg
requested changes
Jan 31, 2024
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
Looks pretty good to me, only minor feedback and a couple of questions.
Nice strategy, I like how you're taking advantage of mbedtls_test_move_handshake_to_state() - bit of a hack, but perfect for testing.
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
mpg
approved these changes
Feb 1, 2024
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
Thanks for addressing my feedback, looks all good to me now!
waleed-elmelegy-arm
approved these changes
Feb 1, 2024
Contributor
waleed-elmelegy-arm
left a comment
waleed-elmelegy-arm
left a comment
There was a problem hiding this comment.
LGTM, Thanks.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TLS 1.3 ticket and early data unit tests that aim to be the basis for ticket and early data negative testing in test_suite_ssl.
PR checklist