TLS 1.3: Enforce max_early_data_size on client #8857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronald-cron-arm
added
enhancement
needs-ci
mpg
previously requested changes
Feb 26, 2024
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
Mostly minor points, the only important one is about handling errors from ssl_write_real().
mpg
requested review from
waleed-elmelegy-arm
and removed request for
waleed-elmelegy-arm
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
ronald-cron-arm
force-pushed
the
tls13-cli-max-early-data-size
branch
from
2cefacf to
3328d8a
Compare
Contributor
Author
ronald-cron-arm
added
needs-ci
Allocate the buffer to write/read early data. That way in ASan builds. buffer overwrite/overread can be detected. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
ronald-cron-arm
force-pushed
the
tls13-cli-max-early-data-size
branch
from
3328d8a to
7c07aab
Compare
ronald-cron-arm
added
the
needs-review
tom-cosgrove-arm
previously approved these changes
Mar 5, 2024
Contributor
tom-cosgrove-arm
left a comment
tom-cosgrove-arm
left a comment
There was a problem hiding this comment.
I have reviewed the rebase (0ee2e4aae-2cefacfdd became 5c4fc9156-aad852376) and the commits de9b03dcb - 7c07aab72 and I am happy with them. Together with @mpg's review this constitutes one approval for this PR.
tom-cosgrove-arm
dismissed
mpg’s stale review
Manuel's requested changes have been made
ronald-cron-arm
dismissed stale reviews from waleed-elmelegy-arm and tom-cosgrove-arm
via
61fd13c
Contributor
Author
|
@tom-cosgrove-arm @waleed-elmelegy-arm following the merge of #8854, this PR had conflicts with development head: test_suite_ssl test cases and test function added at the end of respectively test_suite_ssl.data and test_suite_ssl.function in both PRs. For once I opted for the merge of the development head instead of the rebase to resolve the conflicts. I've done both and resolving the conflicts were easier with the merge. |
ronald-cron-arm
added
priority-very-high
3 tasks
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #8611
On top of #8760, only the last 4 commits belong to this PR.
PR checklist