improve logs and fix some warnings (#1936)

Author: blued-gear

src/Controller/Security/VerifyEmailController.php

@@ -21,7 +21,11 @@ public function __invoke(Request $request, UserRepository $repository, UserManag
             return $this->redirectToRoute('app_register');
         }
 
-        $user = $repository->find($id);
+        try {
+            $user = $repository->find($id);
+        } catch (\Exception) {
+            return $this->redirectToRoute('app_register');
+        }
 
         if (null === $user) {
             return $this->redirectToRoute('app_register');

src/MessageHandler/ActivityPub/Inbox/CreateHandler.php

@@ -95,6 +95,11 @@ public function doWork(MessageInterface $message): void
                     $this->cache->invalidateTags([$tag]);
                     $this->logger->debug('cleared cached items with tag {t}', ['t' => $tag]);
                 }
+            } else {
+                $this->logger->warning('received Create activity for unknown type {t} of object {o}; ignoring', [
+                    't' => $object['type'],
+                    'o' => $object['id'] ?? '<no id>',
+                ]);
             }
         } catch (UserBannedException) {
             $this->logger->info('[CreateHandler::doWork] Did not create the post, because the user is banned');

src/MessageHandler/DeleteUserHandler.php

@@ -54,7 +54,8 @@ public function doWork(MessageInterface $message): void
         if (!$user) {
             throw new UnrecoverableMessageHandlingException('User not found');
         } elseif ($user->isDeleted && null === $user->markedForDeletionAt) {
-            throw new UnrecoverableMessageHandlingException('User already deleted');
+            // user already deleted
+            return;
         }
 
         $isLocal = null === $user->apId;

src/Service/ActivityPub/ApHttpClient.php

@@ -123,7 +123,7 @@ private function getActivityObjectImpl(string $url): ?string
             $content = $response->getContent(false);
             $this->logger->debug('[ApHttpClient::getActivityObjectImpl] URL: {url} - content: {content}', ['url' => $url, 'content' => $content]);
         } catch (\Exception $e) {
-            $this->logRequestException($response, $url, 'ApHttpClient:getActivityObject', $e);
+            $this->logRequestException($response ?? null, $url, 'ApHttpClient:getActivityObject', $e);
         }
 
         return $content;
@@ -447,7 +447,7 @@ public function post(string $url, User|Magazine $actor, ?array $body = null, boo
                 throw new InvalidApPostException('Post failed', $url, $statusCode, $body);
             }
         } catch (\Exception $e) {
-            $this->logRequestException($response, $url, 'ApHttpClient:post', $e, $jsonBody);
+            $this->logRequestException($response ?? null, $url, 'ApHttpClient:post', $e, $jsonBody);
         }
 
         // build cache

src/Service/MentionManager.php

@@ -62,7 +62,7 @@ public function handleChain(ActivityPubActivityInterface $activity): array
             function ($val) {
                 preg_match(RegPatterns::LOCAL_USER, $val, $l);
 
-                return preg_match(RegPatterns::AP_USER, $val) || $val === $l[0] ?? '';
+                return preg_match(RegPatterns::AP_USER, $val) || $val === ($l[0] ?? '');
             }
         );